After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624331 - videobalance: deadlocks/freezes when changing "brightness" property
videobalance: deadlocks/freezes when changing "brightness" property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.23
Other Linux
: Normal normal
: 0.10.25
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-14 11:19 UTC by Filippo Argiolas
Modified: 2010-08-04 11:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
simple vala program to reproduce the freeze (1.47 KB, text/plain)
2010-07-14 11:21 UTC, Filippo Argiolas 		  Details
thread apply all bt (during the lock) (10.72 KB, text/plain)
2010-07-14 11:59 UTC, Filippo Argiolas 		  Details
fix wrong lock order (2.10 KB, patch)
2010-07-14 13:23 UTC, Alessandro Decina 		committed Details | Review

Description Filippo Argiolas 2010-07-14 11:19:48 UTC 
Hi it seems that if I set "brightness" property on a videobalance too quickly (but I'm really not sure that it has anything to do with rate of change, it just happens randomly) the pipeline blocks at some point.

Attaching a simple test case that reproduces it on my netbook (don't know if cpu speed is any way involved).
Comment 1 Filippo Argiolas 2010-07-14 11:21:17 UTC 
Created attachment 165868 [details]
simple vala program to reproduce the freeze

valac --pkg gstreamer-0.10 --pkg gtk+-2.0 balance-test-case.vala
Comment 2 Filippo Argiolas 2010-07-14 11:59:23 UTC 
Created attachment 165871 [details]
thread apply all bt (during the lock)
Comment 3 Alessandro Decina 2010-07-14 13:23:48 UTC 
Created attachment 165879 [details] [review]
fix wrong lock order
Comment 4 Tim-Philipp Müller 2010-07-14 13:38:22 UTC 
Comment on attachment 165879 [details] [review]
fix wrong lock order

Let's wait with this after the release, there's another -good release coming up real soon anyway.
Comment 5 Filippo Argiolas 2010-08-04 07:06:43 UTC 
Ping ;)
If I'm not mistaken -good is open for commits now.
Comment 6 Sebastian Dröge (slomo) 2010-08-04 07:48:57 UTC 
It was already pushed.

commit d5a4da9a6940a7abb0795ff49147c8a1608385fe
Author: Alessandro Decina <alessandro.d@gmail.com>
Date:   Wed Jul 14 15:21:21 2010 +0200

    videobalance: Fix wrong lock order that could lead to a deadlock. Fixes #624
Comment 7 Filippo Argiolas 2010-08-04 07:59:31 UTC 
My bad, didn't check if it was actually committed :P