After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624307 - Add a plugin-list property to PeasEngine
Add a plugin-list property to PeasEngine
Status: RESOLVED FIXED
Product: libpeas
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: libpeas-maint
libpeas-maint
Depends on:
Blocks:
 
 
Reported: 2010-07-14 08:20 UTC by Garrett Regier
Modified: 2010-07-19 17:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Added a plugin-list property to PeasEngine (2.30 KB, patch)
2010-07-14 08:20 UTC, Garrett Regier 		committed Details | Review

Description Garrett Regier 2010-07-14 08:20:04 UTC 
Created attachment 165849 [details] [review]
Added a plugin-list property to PeasEngine

PeasEngine should have a plugin-list property this was the PeasUIPluginManager can connect to it and reload the list when it is changed.
Comment 1 Steve Frécinaux 2010-07-14 09:42:30 UTC 
Review of attachment 165849 [details] [review]:

This one can go, but I'd like you to talk about the rationale in the commit message. Something like "with this property we will be able to track changes in the plugin list and update the manager accordingly" would do.

::: libpeas/peas-engine.c
@@ +481,3 @@
+   * This will be modified when peas_engine_rescan_plugins() is called.
+   *
+   * Note that the list belongs to the engine and should not be modified or freed.

Could you please put the "freed." on the next line? I know glib code is hard to keep within the 78-chars limit, but I think comments are more readable when they are kept as small lines, and 78 chars looks like a good width.
Comment 2 Steve Frécinaux 2010-07-19 17:23:02 UTC 
Attachment 165849 [details] pushed as 616e8f4 - Added a plugin-list property to PeasEngine