GNOME Bugzilla – Bug 624244
nautilus-extension too easily pulls in gtk2 code
Last modified: 2010-12-03 12:50:09 UTC
In Fedora rawhide I'm seeing postr (a nautilus extension using pygtk2) blowing up nautilus. I think the right fix here is not to assume that all extensions are ported atomically; we need to bump the version of nautilus-extensions; /usr/lib/nautilus/extensions-3.0?
Created attachment 165814 [details] [review] Bump version of nautilus-extensions Since Nautilus now links to GTK3, this constitutes an ABI break. We need to bump the version of the extensions directory to ensure we don't load GTK2-using plugins. However, we still create the old directory, which will allow old plugins to install. We just ignore them.
This is a pretty high priority bug for Fedora to switch to using nautilus and GTK3 - without it, the desktop becomes unusable when any gtk2-using plugin gets pulled in.
Review of attachment 165814 [details] [review]: Thanks for the patch; I inlined some comments; shall we also change the Nautilus.gir file to 3.0 (you probably know better than me the naming conventions for .gir files). ::: configure.in @@ +16,3 @@ dnl 2. If any interfaces have been added, then increment current and set revision to 0. dnl Interface break is not allowed. +m4_define(nautilus_extension_current, 4) Probably I'm not the best expert on this, but we bumped this recently already, during this cycle. Is it really necessary to bump it again? ::: libnautilus-extension/Makefile.am @@ +5,3 @@ +install-exec-local: + install -d -m 755 $(DESTDIR)$(libdir)/nautilus/extensions-2.0 + install -d -m 755 $(DESTDIR)$(libdir)/nautilus/extensions-3.0 Why is it necessary to create both directories here? It seems to me did not call `install` for 2.0, so probably it's already something extensions take care of?
*** Bug 630587 has been marked as a duplicate of this bug. ***
I pushed a tweaked version of this patch to master, closing.