After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624244 - nautilus-extension too easily pulls in gtk2 code
nautilus-extension too easily pulls in gtk2 code
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 630587 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-07-13 12:41 UTC by Colin Walters
Modified: 2010-12-03 12:50 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
Bump version of nautilus-extensions (3.51 KB, patch)
2010-07-13 15:54 UTC, Colin Walters
reviewed Details | Review

Description Colin Walters 2010-07-13 12:41:41 UTC
In Fedora rawhide I'm seeing postr (a nautilus extension using pygtk2) blowing up nautilus.  I think the right fix here is not to assume that all extensions are ported atomically; we need to bump the version of nautilus-extensions; /usr/lib/nautilus/extensions-3.0?
Comment 1 Colin Walters 2010-07-13 15:54:04 UTC
Created attachment 165814 [details] [review]
Bump version of nautilus-extensions

Since Nautilus now links to GTK3, this constitutes an ABI break.  We
need to bump the version of the extensions directory to ensure we
don't load GTK2-using plugins.  However, we still create the old
directory, which will allow old plugins to install.  We just ignore them.
Comment 2 Colin Walters 2010-07-13 17:06:18 UTC
This is a pretty high priority bug for Fedora to switch to using nautilus and GTK3 - without it, the desktop becomes unusable when any gtk2-using plugin gets pulled in.
Comment 3 Cosimo Cecchi 2010-07-17 13:05:55 UTC
Review of attachment 165814 [details] [review]:

Thanks for the patch; I inlined some comments; shall we also change the Nautilus.gir file to 3.0 (you probably know better than me the naming conventions for .gir files).

::: configure.in
@@ +16,3 @@
 dnl 2. If any interfaces have been added, then increment current and set revision to 0.
 dnl Interface break is not allowed.
+m4_define(nautilus_extension_current,  4)

Probably I'm not the best expert on this, but we bumped this recently already, during this cycle. Is it really necessary to bump it again?

::: libnautilus-extension/Makefile.am
@@ +5,3 @@
+install-exec-local:
+	install -d -m 755 $(DESTDIR)$(libdir)/nautilus/extensions-2.0
+	install -d -m 755 $(DESTDIR)$(libdir)/nautilus/extensions-3.0

Why is it necessary to create both directories here?
It seems to me did not call `install` for 2.0, so probably it's already something extensions take care of?
Comment 4 Cosimo Cecchi 2010-09-30 13:08:26 UTC
*** Bug 630587 has been marked as a duplicate of this bug. ***
Comment 5 Cosimo Cecchi 2010-12-03 12:50:09 UTC
I pushed a tweaked version of this patch to master, closing.