GNOME Bugzilla – Bug 624243
When editing in eclipse by pressing the tab key the orca sometimes reads the contents of the line
Last modified: 2010-09-20 10:56:19 UTC
Eclipse has a feature called content assist, activated by default by pressing ctrl+space. With this feature we can type part of a command, press CTRL +SPACE and a list of commands that match what you type is shown. We can press tab, browse the list to choose the desired command and press enter. The chosen command is inserted by replacing what was previously typed. If only one command match what was typed, it is automatically inserted. If the command inserted has one or more parameters, the cursor is placed in the name of the first parameter to be edited. The names of the parameters are fake and must be substituted by real names. At this time we can use the tab and shift+tab to navigate between the parameters. What is happening is that when the tab key or shift + tab is pressed, Orca reads the contents of the line instead of just reading the name of the parameter being edited.
Created attachment 165801 [details] [review] revision 1 With this patch orca reads the parameter name when tab or shift+tab is pressed. If the cursor reach the end of the line, after the last parameter, the entire line is read. Pressing tab or shift+tab again, forces the cursor to jump to the first or to the last parameter, and orca reads the parameter name again. Needs to be reviewed. Thanks.
Created attachment 166111 [details] [review] revision 2 Instead of create the function offsetsForSelection, use the function selectedText. No changes in the behavior.
Review of attachment 166111 [details] [review]: Looks good to me! Committed: http://git.gnome.org/browse/orca/commit/?id=f7479a21f10b02f0df0d3bf3d66f34f1c0f122e0 On a related note, I am currently in the process of updating all of Orca's regression tests so that we're prepared to head into the final stretch of GNOME 3.0. And it occurs to me that we really should have regression tests for Eclipse. Could you be persuaded to write some, especially for the bug fixes and script features you've provided? If so that would be awesome. Info can be found on the wiki: http://live.gnome.org/Orca/RegressionTesting. Some of that needs updating, but the basic info you need is there. Getting back to this bug, please feel free to close it out as FIXED if there's no additional work that needs to be done on it. Thanks!
(In reply to comment #3) > On a related note, I am currently in the process of updating all of Orca's > regression tests so that we're prepared to head into the final stretch of GNOME > 3.0. And it occurs to me that we really should have regression tests for > Eclipse. Could you be persuaded to write some, especially for the bug fixes and > script features you've provided? If so that would be awesome. Info can be found > on the wiki: http://live.gnome.org/Orca/RegressionTesting. Some of that needs > updating, but the basic info you need is there. I'll try! > > Getting back to this bug, please feel free to close it out as FIXED if there's > no additional work that needs to be done on it. Thanks! I think that a small change can be made. In the line 74 we have the following line: hasSelection = startOffset > 0 or endOffset > 0 It can be: hasSelection = endOffset > 0 What do you think? Thanks.
> I'll try! Awesomesauce!! Thank you so much. Let me know if you need help. > I think that a small change can be made. > In the line 74 we have the following line: > hasSelection = startOffset > 0 or endOffset > 0 > It can be: > hasSelection = endOffset > 0 True... If you'd like to submit a new patch with that change I'll push it to master.
Created attachment 166160 [details] [review] revision 3 a minor change in the line 74
Comment on attachment 166160 [details] [review] revision 3 Since all that was needed to be committed is the one line change, that was committed. Feel free to close this out as fixed.