After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624232 - treat GFreeFunc the same as GDestroyNotify for callbacks
treat GFreeFunc the same as GDestroyNotify for callbacks
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: introspection
Git master
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-13 10:36 UTC by Jonathan Matthew
Modified: 2010-07-26 23:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.39 KB, patch)
2010-07-13 10:41 UTC, Jonathan Matthew
committed Details | Review

Description Jonathan Matthew 2010-07-13 10:36:32 UTC
A few things use GFreeFunc rather than GDestroyNotify for freeing callback data.  gconf_client_notify_add is one example.  As far as I can see, GFreeFunc should be ignored just as GDestroyNotify is when ensuring that a function being called has only one callback.
Comment 1 Jonathan Matthew 2010-07-13 10:41:16 UTC
Created attachment 165787 [details] [review]
patch

With this patch, I can at least add gconf notifications.  I realise this is not very interesting considering gconf's future.
Comment 2 johnp 2010-07-26 09:52:04 UTC
Comment on attachment 165787 [details] [review]
patch

Looks good, is there any place else that we need to handle FreeFunc?
Comment 3 Jonathan Matthew 2010-07-26 23:28:19 UTC
I can't see any other place where we'd need to do anything special.

Patch pushed as commit 6d7ed6c.