After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624153 - I see performance slowing with Orca after bug 373387 fix
I see performance slowing with Orca after bug 373387 fix
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.31.x
Other All
: Normal normal
: 2.32.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-12 10:37 UTC by Hammer Attila
Modified: 2010-09-20 10:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This debug.out I hope shows why happening this performance problem (130.27 KB, text/plain)
2010-07-12 10:37 UTC, Hammer Attila
  Details
Proposed patch (1.15 KB, patch)
2010-07-12 14:49 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Hammer Attila 2010-07-12 10:37:53 UTC
Created attachment 165717 [details]
This debug.out I hope shows why happening this performance problem

Dear developers,

After bug 373387 bug fix commit, I see performance problem with Orca with my Lucid system. Before this fix I update the Orca git master source code tree with tit pull command and not see this performance problem.
I using Orca git master version.
For example, if I try simple step with Thunderbird message composing fields, Orca some time spokening three second later the actual control. You verify this with following simple test:
1. Launch Thunderbird.
2. Press Ctrl+n key combination.
3. Press tab key, the purpose you go to the message field.
4. Press Shift+Tab key, your purpose now to go to the to: field. I see performance problem when I do this simple test.

Another problem:
When I try navigate with word by word with Thunderbird message field for example, Orca is not spokening the actual word with jumps the caret, or freeze (not speak).

Another problem:
When I typing, Orca some time spokening later the entire typed word, not spokening the actual typed character.

I maked only a debug.out file, with shows for example the I described simple Thunderbird test result, and repeating more time the test steps. Unfortunately I not found why happening this problem.

Following changes are committed with last hours:
commit ed712f3f838ecf02d40e0799dea24dba6324312e
Author: Joanmarie Diggs <joanmarie.diggs@gmail.com>
Date:   Mon Jul 12 03:52:26 2010 -0400

    Fix for bgo#373387 - Users should be able to lock/unlock the "Lock" modifier even if Caps Lock is the Orca modifier

commit 5d3698e64d68c54d55cf73750f4897263d2ca79f
Author: Joanmarie Diggs <joanmarie.diggs@gmail.com>
Date:   Sun Jul 11 07:05:58 2010 -0400

    Reworking of the original fix for bgo#591034 - Caps_lock does not get re-enabled after orca shutdown and when switching from laptop to desktop layout.

commit 85204b679357ce354dd0d8c53a2815b728179ab9
Author: Joanmarie Diggs <joanmarie.diggs@gmail.com>
Date:   Sun Jul 11 04:03:03 2010 -0400

    Fix for bgo#616585 - Numpad 0 can't work after launch and quit orca

Attila
Comment 1 Jose Vilmar Estacio de Souza 2010-07-12 13:51:43 UTC
Here is what I did to try identify where is the problem.

git checkout -b test
git reset --hard  5d369
Compile, install and restart orca.
The problem seems to be gone.
Comment 2 Joanmarie Diggs (IRC: joanie) 2010-07-12 13:57:48 UTC
Thanks José.

That would support what Mike Gorse found. Stupid xmodmap thrashing I bet. :-(
Comment 3 Joanmarie Diggs (IRC: joanie) 2010-07-12 14:05:12 UTC
I see where it's occurring....
Comment 4 Hammer Attila 2010-07-12 14:32:16 UTC
Joanie, Jose, sorry the long answer.
Jose, works for me your method, thanks! Correct reversed the following commit:
commit 5d3698e64d68c54d55cf73750f4897263d2ca79f
Author: Joanmarie Diggs <joanmarie.diggs@gmail.com>
Date:   Sun Jul 11 07:05:58 2010 -0400

    Reworking of the original fix for bgo#591034 - Caps_lock does not get re-enabled after orca shutdown and when switching from laptop to desktop layout."
Unfortunately, when I do reverse operation, the new caps lock toggle method is not working now. This is possible?

Attila
Comment 5 Joanmarie Diggs (IRC: joanie) 2010-07-12 14:49:02 UTC
Created attachment 165740 [details] [review]
Proposed patch

Please test.
Comment 6 Joanmarie Diggs (IRC: joanie) 2010-07-12 14:49:51 UTC
Attila be sure you checkout master before applying this patch.
Comment 7 Jose Vilmar Estacio de Souza 2010-07-12 15:17:09 UTC
Patch applied, works like a charm!
Great job, thanks.
Comment 8 Joanmarie Diggs (IRC: joanie) 2010-07-12 15:49:44 UTC
Comment on attachment 165740 [details] [review]
Proposed patch

http://git.gnome.org/browse/orca/commit/?id=fab99d2bb436b934cef5e883d83b61e936f9e4bb
Comment 9 Hammer Attila 2010-07-13 04:45:51 UTC
Joanie, thank you the commit.
I switched again the master branch before I update Orca, thank you the warning.

Every I prewious see performance problem are solved.

Attila
Comment 10 Joanmarie Diggs (IRC: joanie) 2010-07-13 12:46:59 UTC
(In reply to comment #9)
> Joanie, thank you the commit.
> I switched again the master branch before I update Orca, thank you the warning.
> 
> Every I prewious see performance problem are solved.
> 
> Attila

Phew! And yay! :-) And thank you so much for filing this report so quickly and to everyone for the testing and feedback!