After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624113 - [tags] wrong behaviour in merge function for strings
[tags] wrong behaviour in merge function for strings
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal minor
: 0.10.30
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-11 17:18 UTC by Eduardo Dobay
Modified: 2010-07-11 18:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix in gst_tag_merge_strings_with_comma (367 bytes, patch)
2010-07-11 17:18 UTC, Eduardo Dobay 		committed Details | Review

Description Eduardo Dobay 2010-07-11 17:18:47 UTC 
Created attachment 165688 [details] [review]
Fix in gst_tag_merge_strings_with_comma

After creating a test ogg file and inserting multiple artist fields in it, I ran a program written by me that extracts the metadata from a file via GStreamer (using gst_tag_list_get_string for the string fields), and got the following oddity:

$ vorbiscomment -w -t "ARTIST=foo" -t "ARTIST=bar" -t "ARTIST=baz" -t "ARTIST=qux" -t "ARTIST=quux" test.ogg
$ ./metadata test.ogg
artist: foo, bar, bar, bar, bar

i.e. after the second occurrence of the artist tag, the second field value is always used. The solution is very simple (just one character in gst/gsttaglist.c) and the patch is attached.
Comment 1 Tim-Philipp Müller 2010-07-11 18:07:27 UTC 
Oops, thanks for the patch.


commit c082281d280d375d19d5e8a9bd3bc71a9c6c23cb
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Sun Jul 11 19:00:54 2010 +0100

    checks: add unit test for recent taglist merge_strings_with_comma fix
    
    See #624113.

commit e86cfe1a19ce97417b7364b02f95d84f8340178f
Author: Eduardo Dobay <edudobay@gmail.com>
Date:   Sun Jul 11 18:59:53 2010 +0100

    taglist: fix merge_strings_with_comma() for more than two strings
    
    Fixes #624113.