After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623918 - [typefind] Extend AAC typefinder to detect LOAS stream
[typefind] Extend AAC typefinder to detect LOAS stream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-09 08:45 UTC by Andrzej K. Haczewski
Modified: 2010-10-14 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] typefinding: extend AAC typefinder for LOAS stream (4.36 KB, patch)
2010-07-09 08:45 UTC, Andrzej K. Haczewski 		committed Details | Review

Description Andrzej K. Haczewski 2010-07-09 08:45:01 UTC 
Created attachment 165535 [details] [review]
[PATCH] typefinding: extend AAC typefinder for LOAS stream

Attached patch to detect LOAS AAC stream.
Comment 1 Andrzej K. Haczewski 2010-07-09 08:45:46 UTC 
Should have mark it as enhancement.
Comment 2 Tim-Philipp Müller 2010-07-09 09:00:12 UTC 
Great, thanks!

One question: why did you put the error-resilient=true/false into the caps? Do you expect that there are decoders that can only handle one type?
Comment 3 Andrzej K. Haczewski 2010-07-09 10:24:27 UTC 
Just as I said in comment, it is strictly informative. Decoder has to parse LOAS and LATM inside if it wants to be compliant, but in example if you want to mux LATM frames into something different like FlexMux or MP4, then having that information you can quickly skip 3 or 7 bytes of LOAS header to get to LATM for muxing without parsing LOAS header.
Comment 4 Tim-Philipp Müller 2010-10-14 15:50:40 UTC 
Committed with minor changes, thanks for the patch!

commit 6c5cee1d02956e7ad6e692687c3c50daa023736c
Author: Andrzej K. Haczewski <ahaczewski@gmail.com>
Date:   Thu Jul 8 15:22:08 2010 +0200

    typefinding: extend AAC typefinder to detect LOAS streams
    
    Extend AAC typefinder to recognize LOAS stream as specified by
    ISO/IEC 14496-3:2009.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=623918