After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623887 - "Contour plot": missing class in legend if a minimum value is entered manually
"Contour plot": missing class in legend if a minimum value is entered manually
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Charting
1.10.x
Other Linux
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2010-07-08 20:47 UTC by Nihil Baxter
Modified: 2010-07-13 19:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
contour plot with missing class (12.41 KB, application/pdf)
2010-07-08 20:48 UTC, Nihil Baxter
  Details
proposed patch (980 bytes, patch)
2010-07-10 10:43 UTC, Jean Bréfort
committed Details | Review
gnumeric file example contour plot with missing class (33.50 KB, application/x-gnumeric)
2010-07-12 21:12 UTC, Nihil Baxter
  Details
Does the contour plot looks same in your goffice and gnumeric version? (8.92 KB, application/pdf)
2010-07-12 21:14 UTC, Nihil Baxter
  Details
contour plot with goffice from current git with patch applied (in gnumeric from current git) (122.60 KB, image/png)
2010-07-12 21:29 UTC, Andreas J. Guelzow
  Details

Description Nihil Baxter 2010-07-08 20:47:00 UTC
If you specify a minimum value for the "countour plot" in the menu option "pseudo-3D-axis" the class above the first class is missing (see the attachment)

And if you specify a maximum value the last class is not a class. It is a single value. This value is the same as the higher value of the class border below. 

and by the way... It would be very helpfull to specify the colour of each class manually in the contour plot (maybe the same way as in the histogram chart where you can define a different colour for each bar with "point")
Comment 1 Nihil Baxter 2010-07-08 20:48:56 UTC
Created attachment 165519 [details]
contour plot with missing class
Comment 2 Andreas J. Guelzow 2010-07-08 21:46:13 UTC
Major: Major loss of functionality - menu item broken, data output extremely incorrect, or otherwise difficult/useless to use.
Comment 3 Andreas J. Guelzow 2010-07-08 22:55:23 UTC
Would you be able to provide the gnumeric file corresponding to the attached pdf?

I suspect what is happening is that there aren't any data values below 200000 at all,so the legend omits those categories. (and your minimum forces an additional (unneeded category.)
Comment 4 Andreas J. Guelzow 2010-07-08 22:57:04 UTC
More importantly it seems that the colour block for the highest valued category which ought to be turquoise (or whatever the colour is called) appears to be missing.
Comment 5 Andreas J. Guelzow 2010-07-09 07:05:30 UTC
The problem seems to occur whenever the manual minimum is below the automatic minimum. In that case:
1) the second group is missing
2) the limits for the last (highest) group are wrong
3) the listed colours seem to correspond to the correct sequence for classes (not the really listed classes).
Comment 6 Jean Bréfort 2010-07-10 10:43:17 UTC
Created attachment 165618 [details] [review]
proposed patch

Please test with this patch.
Comment 7 Nihil Baxter 2010-07-12 08:05:52 UTC
(In reply to comment #6)
> Created an attachment (id=165618) [details] [review]
> proposed patch
> 
> Please test with this patch.

Yesterday I tryed this patch. Maybe I made a mistake applaying the patch. I only recompiled goffice-0.8.7 after applaying the patch and not gnumeric-1.10.7 itself.

The result was that I have only seen one class in the legend. But this class consists of the lowest value of the first class and the highest value of the last class. All the other classes in between you could see in the contour plot chart but not in the legend.

Later I will attach a contour plot example. But maybe you have made the same experiance with the patch.
Comment 8 Jean Bréfort 2010-07-12 08:48:22 UTC
hmm, recompilation of goffice might be not enough, you probably need to reinstall the plugin. Things work for me, but I'm interested if you can provide a not working sample.
Comment 9 Andreas J. Guelzow 2010-07-12 16:03:25 UTC
With this patch I cannot replicate the problem anymore.
Comment 10 Nihil Baxter 2010-07-12 21:10:38 UTC
(In reply to comment #9)
> With this patch I cannot replicate the problem anymore.

I just installed the latest goffice from GIT and gnumeric-1.10.8 from GIT but the problem seem to be the same as before. You can find a gnumeric file with a contour plot in the attachment.
Comment 11 Nihil Baxter 2010-07-12 21:12:39 UTC
Created attachment 165761 [details]
gnumeric file example contour plot with missing class
Comment 12 Nihil Baxter 2010-07-12 21:14:43 UTC
Created attachment 165762 [details]
Does the contour plot looks same in your goffice and gnumeric version?
Comment 13 Andreas J. Guelzow 2010-07-12 21:25:45 UTC
The "latest goffice from GIT and gnumeric-1.10.8 from GIT" does not include the above patch. We will not be applying the patch to git until we are reasonably sure that it fixes this issue.

So you will need to apply that patch to your source (patch -p1 <filename)
and recompile goffice (and ideally gnumeric although that should not be necessary).
Comment 14 Andreas J. Guelzow 2010-07-12 21:29:38 UTC
Created attachment 165763 [details]
contour plot with goffice from current git with patch applied (in gnumeric from current git)
Comment 15 Jean Bréfort 2010-07-13 06:29:56 UTC
The grid appearing in the pdf is annoying. But there might be no easy solution for that.
Comment 16 Andreas J. Guelzow 2010-07-13 07:45:41 UTC
Jean, I am pretty sure that your patch is fixing this problem. Please commit (and close this bug).
Comment 17 Jean Bréfort 2010-07-13 08:21:30 UTC
Fixed. Thanks for your bug report.
Comment 18 Nihil Baxter 2010-07-13 19:03:26 UTC
Seems to work with the latest GIT 
Thanks for fixing the bug.