After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623883 - [winks] gstksvideosrc.c error on MSVC using gst_element_class_set_details()
[winks] gstksvideosrc.c error on MSVC using gst_element_class_set_details()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.19
Other Windows
: Normal normal
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-08 20:19 UTC by David Hoyt
Modified: 2010-07-08 20:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes MSVC warning/error. (582 bytes, patch)
2010-07-08 20:19 UTC, David Hoyt
committed Details | Review

Description David Hoyt 2010-07-08 20:19:21 UTC
Created attachment 165517 [details] [review]
Fixes MSVC warning/error.

The following warning and error is emitted on gstksvideosrc.c using MSVC:

sys\winks\gstksvideosrc.c(158) : warning C4133: 'function' : incompatible types - from 'char [11]' to 'const GstElementDetails *'
sys\winks\gstksvideosrc.c(159) : error C4020: 'gst_element_class_set_details' : too many actual parameters

Changing it to call gst_element_class_set_details_simple() instead resolves the issue.
Comment 1 Tim-Philipp Müller 2010-07-08 20:56:12 UTC
Thanks, committed:

 commit e467a3e14b48bffc31b088dbfe011970d10b359e
 Author: David Hoyt <dhoyt@llnl.gov>
 Date:   Thu Jul 8 21:53:35 2010 +0100

    winks: fix compilation by using the right function
    
    Fixes #623883.