After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623845 - [P12] Use -Bsymbolic
[P12] Use -Bsymbolic
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.90.x
Other All
: Normal normal
: 3.0
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-07-08 15:18 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-07-10 00:59 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
Add check for -Bsymbolic-functions linker flag (1.14 KB, patch)
2010-07-08 15:19 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Use -Bsymbolic-functions (1.83 KB, patch)
2010-07-08 15:20 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
gdk/: fully remove gdkalias hacks (50.18 KB, patch)
2010-07-09 15:58 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
gtk/: fully remove gtkalias hacks (129.43 KB, patch)
2010-07-09 17:23 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-07-08 15:18:35 UTC 
This is one of the preparative tasks for GTK+3: http://live.gnome.org/GTK+/3.0/Tasks#P12

This is already done in Glib.
Comment 1 Javier Jardón (IRC: jjardon) 2010-07-08 15:19:45 UTC 
Created attachment 165485 [details] [review]
Add check for -Bsymbolic-functions linker flag
Comment 2 Javier Jardón (IRC: jjardon) 2010-07-08 15:20:12 UTC 
Created attachment 165486 [details] [review]
Use -Bsymbolic-functions
Comment 3 Matthias Clasen 2010-07-08 16:12:16 UTC 
These patches look ok to me, but we should also get the cleanup parts done, ie remove the disable-visiblity stuff from configure, drop the gtkalias.h etc generation, drop the #includes from all sources.
Comment 4 Javier Jardón (IRC: jjardon) 2010-07-09 15:58:16 UTC 
Created attachment 165562 [details] [review]
gdk/: fully remove gdkalias hacks
Comment 5 Javier Jardón (IRC: jjardon) 2010-07-09 17:23:25 UTC 
Created attachment 165567 [details] [review]
gtk/: fully remove gtkalias hacks
Comment 6 Matthias Clasen 2010-07-09 23:31:14 UTC 
Ryan pointed out on irc that the glib configure has meanwhile grown a --disable-bsymbolic option that we should copy over as well.
Comment 7 Matthias Clasen 2010-07-09 23:32:29 UTC 
Other than that, looks fine
Comment 8 Javier Jardón (IRC: jjardon) 2010-07-10 00:55:38 UTC 
Comment on attachment 165485 [details] [review]
Add check for -Bsymbolic-functions linker flag

committed an improved version with the new --disable-Bsymbolic option
commit e4e477161ae617a35528c0659f00284f4c80c372
Comment 9 Javier Jardón (IRC: jjardon) 2010-07-10 00:56:02 UTC 
Comment on attachment 165486 [details] [review]
Use -Bsymbolic-functions

commit 7cabad6b77df866b59b8b98b8c8efaa6e89fd590
Comment 10 Javier Jardón (IRC: jjardon) 2010-07-10 00:56:22 UTC 
Comment on attachment 165562 [details] [review]
gdk/: fully remove gdkalias hacks

commit 404e7d0e0013355549578db5c3981943f536c2b9
Comment 11 Javier Jardón (IRC: jjardon) 2010-07-10 00:56:40 UTC 
Comment on attachment 165567 [details] [review]
gtk/: fully remove gtkalias hacks

commit 0a07e9733bb259598a09515a3e4cdbcda5feef57
Comment 12 Javier Jardón (IRC: jjardon) 2010-07-10 00:59:15 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release.

Thanks for your review.