After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623825 - Regression: Orca speaks unselected XUL radio buttons in Gecko dialog boxes
Regression: Orca speaks unselected XUL radio buttons in Gecko dialog boxes
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 2.32.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2010-07-08 11:34 UTC by Hammer Attila
Modified: 2010-09-20 10:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This is the Orca 2.30.2 version maked debug.out file (116.69 KB, application/octet-stream)
2010-07-08 11:34 UTC, Hammer Attila
Details
This is Orca git master version maked debug.out (148.77 KB, application/octet-stream)
2010-07-08 11:42 UTC, Hammer Attila
Details

Description Hammer Attila 2010-07-08 11:34:56 UTC
Created attachment 165466 [details]
This is the Orca 2.30.2 version maked debug.out file

Dear Developers,

When I try downloading a file with Mozilla Firefox, the first presented dialog (what you would like to do this file) Orca do interesting thinks when I try navigate the open or save radio button elements.
Unfortunately, this is depending Orca version number. In 2.30.2 version, when the radiobutton default item is "save file" (fájl mentése in hungarian translation), if I press up arrow, not happening mistake, Orca only right spokening the prewious selected ratiobutton item. But if I press down arrow again, Orca spokening the "save file" radiobutton element, and the cursor jumps with Ok button.
How can you try reproduce this?
If you using Orca 2.30.2 version and Firefox 3.6.6 version, try downloading a file and try navigate the presented radio button.

I wroted next comment what happening if I using Orca git master version. I very hope only my system is broken, and you not reproduced any me writed problem.
I using Ubuntu Lucid, Firefox 3.6.6 and Orca 2.30.2 or Orca git master version, depending my need testing.
Attila
Comment 1 Hammer Attila 2010-07-08 11:42:15 UTC
Created attachment 165468 [details]
This is Orca git master version maked debug.out

I maked debug.out file similar with Orca 2.30.2 version.
I only do following test:
1. Click a downloadable file with Firefox.
2. I try navigate with radio button elements. If I press up arrow key, Orca right spokened me the new radiobutton element, but spoken not selected (nincs kiválasztva in hungarian translation). If I try select back with save file radiobutton element (fájl mentése), Orca only spokening Ok button.

Why happening this different working with Orca 2.30.2 and Orca Git master version. Not need happening only Orca spokening the actual selected or changed radiobutton element, and not jump the cursor with Ok button.
Or this is a Firefox bug?

I very hope this is not an Orca problem and my system only broken.

Attila
Comment 2 Joanmarie Diggs (IRC: joanie) 2010-07-10 07:03:56 UTC
The reason Orca is saying "not selected" but only with master seems to be a side effect of a change I made only in master to get braille to update correctly with radio buttons, i.e. bug 622811. This is why, by the way, I'm so insistent about the high-impact, low-risk rule for the stable branch. <smile>

I've not yet been able to reproduce the problem you describe regarding the cursor jump. I'll try some more later.

Thanks for the report!
Comment 3 Joanmarie Diggs (IRC: joanie) 2010-07-10 07:25:41 UTC
Attila, I have just committed a fix to master for the "unselected" issue:

http://git.gnome.org/browse/orca/commit/?id=7aa7ddc1e680df15fd7cc0c9f8baecb1da38d794

As for the focus-change you're seeing with 2.30.2

1. GNOME 2.30.2 is the last official release of 2.30
2. The problem is not seen in master

So I'm not sure what I should do to address it even if I manage to reproduce which, like I said, I've not yet been able to do.

Therefore, could you please verify that everything is now working as you'd expect with Orca from master?

Thanks!
Comment 4 Hammer Attila 2010-07-10 15:56:57 UTC
Joanie, unselected issue is correct fixed with master branch, thank you the fix.
But unfortunately the focus jump issue is still present my machine with Firefox 3.6.6 version with download dialog radiobutton control.
If I press up arrow key the download question radio button, Orca fine speak the open radio button element and not jumps focus with Ok button, if I press down arrow, Orca not spokening the save file radiobutton item, spokening Ok button and the focus jumps the Ok button.
If I tabbing again the radio button, and try press Up arrow key, Orca jumps automaticaly the focus with Ok button and not spokening the "Open file" radio button element.
This is only my system error or this is a Firefox 3.6.6 issue your openion? Absolute interesting this problem.
If help you, monday morning I do an english language based updated debug.out file, because tomorrow I am not in home unfortunately.

Attila
Comment 5 Joanmarie Diggs (IRC: joanie) 2010-07-10 17:12:18 UTC
Attila, I don't think what you're describing is an Orca bug.

1. Orca does not control the caret in dialog boxes.

2. Looking at your debug.out, Orca knows that it's in a dialog box.

3. Looking at your debug.out, the Firefox dialog's OK button is claiming to have focus. Therefore we are presenting that to you. I see no evidence that we (Orca) are moving focus there. I believe something else is moving focus there.

4. We have seen similar, weird focus grabbing issues from Gecko (e.g. Steve's bookmark manager bug).

Things you could try:

1. If possible, with sighted assistance, perform the same steps but without Orca running. Does the focus grab still occur? If so, it's a Firefox bug.

2. Quit Firefox. Rename your .mozilla to something else (e.g. .mozilla-old). Relaunch Firefox. It will be like a fresh install for a new user. Do not change any preferences at all. Just try to reproduce the problem. Does it still occur? If it does not, then it's something related to one of your Firefox preferences.

3. Get a different version of Firefox from Mozilla, e.g. 3.6.8. And see if the problem occurs.

4. Ask on the Orca list.
Comment 6 Hammer Attila 2010-07-11 05:11:03 UTC
Joanie, thank you your answer. Monday I look this problem detailed with your suggested steps.

Attila
Comment 7 Hammer Attila 2010-07-12 04:45:32 UTC
Joanie, I think I found why producing Firefox with this surprise working method in Download dialog radio button.
The problem is present if the "cursor browsing" is toggled on with F7 key. Prewious time I turned on the cursor browsing with F7 key, because if this feature is turned off by default, the Pageup and Pagedown key combination is not working, not possible to scroll the pages with web browsing when Orca is running. If the cursor browsing feature is turned off, wonderful possible navigate the radio buttons with download dialog, and the focus does'nt jump with Ok button. So, if you want, I mark this bug with resolved fixed status, because the unselected message spokening problem is correct fixed in Master version.

Can you help me verify pageup/pagedown working without Orca is running if cursor browsing is turned off before I open a new bugreport with this problem related?

Attila
Comment 8 Joanmarie Diggs (IRC: joanie) 2010-07-12 05:21:40 UTC
> The problem is present if the "cursor browsing" is toggled on with F7 key.

Dang. Good detective work Attila. I just tried setting always browse pages with the caret to on in 3.6.4 in Ubuntu. And, yes, I can confirm that with that setting enabled, pressing Down Arrow in the radio button group does jump focus to OK all by itself and without Orca running.

So, yeah, it's a Firefox bug.

As for this:

> Can you help me verify pageup/pagedown working without Orca is running if
> cursor browsing is turned off before I open a new bugreport with this problem
> related?

Without Orca running, it scrolls the page; it doesn't move the cursor. And I believe that's on purpose.

If I'm following what you're saying, if you could get them to fix the focus issue, your other problems would be solved. (right?)

Closing this bug as FIXED because this bug is fixed. :-)
Comment 9 Hammer Attila 2010-07-12 05:37:26 UTC
Yes, if the cursor browsing feature turned off, the radiobutton "mistific" problem is entire solved. :-):-)
But, if the cursor browsing is turned off (this is the default), unable to scroll webpages with page down and page up keys. Your openion possible do any Orca related fix with this scrolling problem if this feature is turned off, or this is absolute impossible because the cursor position is not changed if this feature turned off?

I ask this, because I not want you tired unneed bugreport with this problem related if absolute impossible fix this problem with Orca level. :-):-)

Attila
Comment 10 Joanmarie Diggs (IRC: joanie) 2010-07-12 07:23:17 UTC
Attila, I don't believe anything is absolutely impossible to fix. :-) You just have to be persistent and patient. :-)

However, the more we hack around genuine Mozilla bugs in Orca:
1. The more likely we are to introduce bugs in Orca.
2. The more likely we are to make performance in Orca worse.
3. We are giving the Mozilla guys an excuse to not fix their own bugs.
4. We are taking time away from actual Orca bugs.

So my spending time to hack around this issue when the Mozilla guys should be fixing it (i.e. by stopping the focus grab) will be a low priority. That doesn't mean you shouldn't file a bug against Orca if you'd like; just that I won't be getting to it any time soon. Sorry!