After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623807 - [audioclock] Add gst_audio_clock_new_full() with GDestroyNotify for the user_data
[audioclock] Add gst_audio_clock_new_full() with GDestroyNotify for the user_...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal major
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-08 06:38 UTC by Sebastian Dröge (slomo)
Modified: 2010-07-16 15:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
audioclock: API: Add gst_audio_clock_new_full() with a GDestroyNotify for the user_data (5.27 KB, patch)
2010-07-08 06:38 UTC, Sebastian Dröge (slomo)
none Details | Review
audioclock: API: Add gst_audio_clock_new_full() with a GDestroyNotify for the user_data (5.33 KB, patch)
2010-07-08 19:41 UTC, Sebastian Dröge (slomo)
committed Details | Review
baseaudiosrc: Use new gst_audio_clock_new_full() (1.17 KB, patch)
2010-07-08 19:43 UTC, Sebastian Dröge (slomo)
committed Details | Review
baseaudiosink: Use new gst_audio_clock_new_full() (1.27 KB, patch)
2010-07-08 19:43 UTC, Sebastian Dröge (slomo)
committed Details | Review
pulsesink: Post clock-provide/clock-lost when going to/from PAUSED (2.26 KB, patch)
2010-07-08 19:44 UTC, Sebastian Dröge (slomo)
none Details | Review

Description Sebastian Dröge (slomo) 2010-07-08 06:38:05 UTC
See summary
Comment 1 Sebastian Dröge (slomo) 2010-07-08 06:38:19 UTC
Created attachment 165456 [details] [review]
audioclock: API: Add gst_audio_clock_new_full() with a GDestroyNotify for the user_data

Elements usually use their own instance as instance data but the
clock can have a longer lifetime than their elements and the clock
doesn't own a reference of the element.
Comment 2 Sebastian Dröge (slomo) 2010-07-08 19:41:13 UTC
Created attachment 165511 [details] [review]
audioclock: API: Add gst_audio_clock_new_full() with a GDestroyNotify for the user_data

Elements usually use their own instance as instance data but the
clock can have a longer lifetime than their elements and the clock
doesn't own a reference of the element.
Comment 3 Sebastian Dröge (slomo) 2010-07-08 19:43:45 UTC
Created attachment 165512 [details] [review]
baseaudiosrc: Use new gst_audio_clock_new_full()
Comment 4 Sebastian Dröge (slomo) 2010-07-08 19:43:56 UTC
Created attachment 165513 [details] [review]
baseaudiosink: Use new gst_audio_clock_new_full()
Comment 5 Sebastian Dröge (slomo) 2010-07-08 19:44:50 UTC
Created attachment 165514 [details] [review]
pulsesink: Post clock-provide/clock-lost when going to/from PAUSED

Also use gst_audio_clock_new_full() to prevent crashes when the
clock is used after the element was destroyed.
Comment 6 Sebastian Dröge (slomo) 2010-07-16 15:42:53 UTC
commit ed271ff809c193ce3a3c6a89a0bdec4aedc52391
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri Jul 9 17:15:55 2010 +0200

    baseaudiosink: Post clock-provide and clock-lost messages when going from/to

commit e84c7f02b4a8ff402c463ee5175cd4c4d78dcbd3
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri Jul 9 17:15:35 2010 +0200

    baseaudiosrc: Post clock-provide and clock-lost messages when going from/to 


commit f1ac770f1b1ee646f93d76bbc897f7b634923699
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Jul 8 09:54:40 2010 +0200

    baseaudiosink: Use new gst_audio_clock_new_full()

commit 32b0b0aef9db9a33bcefcdd1d8f7ad7ca68e43cf
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Jul 8 09:54:29 2010 +0200

    baseaudiosrc: Use new gst_audio_clock_new_full()

commit 8989ad93d94f1f99a8ad238456fefd914b966b7f
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Jul 8 08:32:22 2010 +0200

    audioclock: API: Add gst_audio_clock_new_full() with a GDestroyNotify for th
    
    Elements usually use their own instance as instance data but the
    clock can have a longer lifetime than their elements and the clock
    doesn't own a reference of the element.
    
    Fixes bug #623807.