After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623806 - [pipeline] Doesn't update the clock if the currently used one gets lost and the start time did not change
[pipeline] Doesn't update the clock if the currently used one gets lost and t...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-08 05:51 UTC by Sebastian Dröge (slomo)
Modified: 2010-07-16 15:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pipeline: If the currently used clock gets lost update it the next time when going from PAUSED to playing (1.54 KB, patch)
2010-07-08 05:51 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2010-07-08 05:51:00 UTC 
This happens for example in playbin2's gapless mode, where the pipeline already goes to PAUSED because a video sink is added and then the clock gets lost because the audio sink (which provided the clock) gets removed.

The attached patch fixes this but I'm not 100% sure if it's entirely correct. Also a gst_element_get_clock() would still return the old, broken clock until the next PAUSED->PLAYING transition but that's probably not a problem.
Comment 1 Sebastian Dröge (slomo) 2010-07-08 05:51:52 UTC 
Created attachment 165455 [details] [review]
pipeline: If the currently used clock gets lost update it the next time when going from PAUSED to playing
Comment 2 Sebastian Dröge (slomo) 2010-07-16 15:36:19 UTC 
commit 9d0e2e7252398c660c33c79256333f76a6d97dd0
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Jul 8 07:48:07 2010 +0200

    pipeline: If the currently used clock gets lost update it the next time when
    
    Fixes bug #623806.