After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623795 - URI at the end of text isn't clickable
URI at the end of text isn't clickable
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
2.30.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2010-07-07 23:39 UTC by Patrick OCallaghan
Modified: 2010-07-08 19:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
eds patch (659 bytes, patch)
2010-07-08 18:17 UTC, Milan Crha
committed Details | Review

Description Patrick OCallaghan 2010-07-07 23:39:26 UTC
A URL in the last line of email messages (such as the reference to the list admin page on many mailing list posts), isn't being highlighted by Evolution 2.30.2, i.e. it isn't clickable. This appears to be GtkHTML-related, see http://mail.gnome.org/archives/evolution-list/2010-July/msg00075.html

gtkhtml2-2.11.1-7.fc13.x86_64
Comment 1 Milan Crha 2010-07-08 11:41:49 UTC
Confirming, I see this on actual master too. The package name is gtkhtml3 :)
Comment 2 Milan Crha 2010-07-08 18:17:58 UTC
Created attachment 165501 [details] [review]
eds patch

for evolution-data-server;

Aha, I thought this is something with "magic links" in GtkHTML, so I suggested this product, but after more investigation I realized that this is done in eds' camel, when converting text/plain parts to HTML. The cause is that the whole text is pushed to the converter, even with the ending \0 (which is finally converted into HTML as "�", but it's unrelated to this). The ending '\0' confuses camel's URL scanner enough to not recognize the last URL in the text.

I'm not able to track down where the ending \0 is added, neither what it may do when it would be removed, thus I will rather just shorten the buffer by one when it contains ending \0 when passing to the URL scanner, which is fixing the issue.
Comment 3 Milan Crha 2010-07-08 19:23:58 UTC
Created commit 341cd23 in eds master (2.31.5+)
Created commit f6e680f in eds gnome-2-30 (2.30.3+)