GNOME Bugzilla – Bug 623775
Adjust for g-i change to remove machine-independent type tags
Last modified: 2010-07-09 18:29:27 UTC
See bug 623774.
Created attachment 165433 [details] [review] Adjust for g-i change to remove machine-independent type tags
Review of attachment 165433 [details] [review]: Looks good, should land as soon as the g-i patch lands. ::: gi/arg.c @@ +124,2 @@ static GITypeTag normalize_int_types(GITypeTag type) { Can't you just inline type_tag_from_size() in the switch cases, sounds simpler to me. Assuming we don't have plans to introduce more machine dependent types. ::: test/js/testEverythingBasic.js @@ +74,3 @@ assertEquals(-42, Everything.test_double(-42)); + let now = Math.floor(new Date().getTime() / 1000); Unrelated change, please exclude.
(In reply to comment #2) > Review of attachment 165433 [details] [review]: > > Looks good, should land as soon as the g-i patch lands. > > ::: gi/arg.c > @@ +124,2 @@ > static GITypeTag > normalize_int_types(GITypeTag type) { > > Can't you just inline type_tag_from_size() in the switch cases, sounds simpler > to me. > Assuming we don't have plans to introduce more machine dependent types. OK. > ::: test/js/testEverythingBasic.js > @@ +74,3 @@ > assertEquals(-42, Everything.test_double(-42)); > > + let now = Math.floor(new Date().getTime() / 1000); > > Unrelated change, please exclude. It is related - we removed the date type, so now we need to operate in terms of a number. Because javascript uses double, for reliability we need to floor them before comparison.
Updated for comments and committed.