After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623639 - Work around g-ir-scanner problem with Gdk.Rectangle
Work around g-ir-scanner problem with Gdk.Rectangle
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2010-07-05 21:54 UTC by Owen Taylor
Modified: 2010-07-06 19:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Work around g-ir-scanner problem with Gdk.Rectangle (2.81 KB, patch)
2010-07-05 21:54 UTC, Owen Taylor 		reviewed Details | Review
Work around g-ir-scanner problem with Gdk.Rectangle (2.85 KB, patch)
2010-07-06 19:00 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2010-07-05 21:54:36 UTC 
g-ir-scanner is currently buggy and confuses the Gdk.Rectangle alias
with MetaRectangle. Since this is moderately hard to fix in
gobject-introspection and the fix would conflict with in-progress
changes, work around by doing a 'sed job' on the generated Meta.gir.
Comment 1 Owen Taylor 2010-07-05 21:54:38 UTC 
Created attachment 165312 [details] [review]
Work around g-ir-scanner problem with Gdk.Rectangle
Comment 2 Colin Walters 2010-07-06 18:48:33 UTC 
Review of attachment 165312 [details] [review]:

::: src/fix-meta-rectangle.py
@@ +15,3 @@
+# gobject-introspection currently has a bug where an alias like
+import sys
+#!/usr/bin/python

This isn't atomic and will cause problems for builds interrupted with SIGINT.

@@ +19,3 @@
+# gobject-introspection currently has a bug where an alias like
+import sys
+#!/usr/bin/python

I'd prefer: o.write(line)
Comment 3 Owen Taylor 2010-07-06 19:00:08 UTC 
Created attachment 165378 [details] [review]
Work around g-ir-scanner problem with Gdk.Rectangle

Make writing out the file atomic
Comment 4 Colin Walters 2010-07-06 19:09:43 UTC 
Review of attachment 165378 [details] [review]:

Looks fine
Comment 5 Owen Taylor 2010-07-06 19:13:05 UTC 
Attachment 165378 [details] pushed as 7853bb8 - Work around g-ir-scanner problem with Gdk.Rectangle