GNOME Bugzilla – Bug 623590
Help user in showing how to import music into banshee
Last modified: 2020-03-17 08:55:28 UTC
I find that the first time you launch banshee, if you don't have music already imported, someone can be a little bit puzzled. It's even more clear in the MeeGo interface (even if MeeGo workarounds this in providing good jazzy music by default ;)). I have some difficulty to go into the Banshee code to understand the whole map, a first approach discussed with alexk seems to change the base class (FLSC) to Show/Hide the library and replace it by some label saying "you need to import in …" or "add some music to ~/Music" for instance. I've tried to detect some change in the Model (number of available Music) in FLSC.SetModel() as suggested, but I don't really understand how it works as it seems to be only called with model and view.Model set to null there. Even when the model should contain albums/tracks… Another approach (maybe more lightweight), suggested by Bertand is to use a use a SourceMessage. He proposed a patch (http://pastebin.com/S1UHpUnc) and it's working well in the traditional interface. The issue is that the MeeGo interface should contain a SourceMessage connected to that signal too. Lamalex made a patch in that direction too and will post the patch there. Associated mailing list discussion: http://mail.gnome.org/archives/banshee-list/2010-June/msg00069.html
Created attachment 165274 [details] [review] Show's a Source message when music library is empty
Created attachment 165275 [details] [review] Wires the meego interface up to display source messages.
Created attachment 165276 [details] [review] Adds a source message to the Music library when the library is empty, and wires up the meego interface to display it. Sorry about the other two. I realized I should rebase and submit as a single patch.
Review of attachment 165276 [details] [review]: I think the idea of helping people get started is good, but I think telling them "Please move your music to {0}" would be confusing. What if they don't yet have any music on the device at all? Perhaps better would be something like "Your library is empty! [Set Library Folder] [Import Music]" where the things in brackets are right-aligned buttons/actions (which the MessageBar thing already supports).
Review of attachment 165276 [details] [review]: ::: src/Core/Banshee.Services/Banshee.Library/MusicLibrarySource.cs @@ +87,3 @@ + DatabaseTrackModel.Reloaded += delegate { + if (TrackModel.Count == 0) { + SetStatus (String.Format ("Please move your music to {0}", GetDefaultBaseDirectory ()), This should be made ready for translations with something like : SetStatus (String.Format (Catalog.GetString ("Please move your music to {0}"), ... @@ +90,3 @@ + false, false, "dialog-info"); + } else { + HideStatus (); We could unsubscribe from the event at this point, because once there are tracks in the library, there no point in checking again. Of course this means the anonymous delegate must be turned into a proper method.
(In reply to comment #4) > Review of attachment 165276 [details] [review]: > > I think the idea of helping people get started is good, but I think telling > them "Please move your music to {0}" would be confusing. What if they don't > yet have any music on the device at all? Perhaps better would be something > like > > "Your library is empty! [Set Library Folder] [Import Music]" > > where the things in brackets are right-aligned buttons/actions (which the > MessageBar thing already supports). I think this is a much better solution, but I don't think those two button names are right (the problem being I can't think of better names). The two don't feel mutually exclusive, they almost feel like you click one and then the other. What about just having one or the other? I think maybe just having Import Music would be good.
Created attachment 186010 [details] [review] Show a message if the library is empty This patch improves on the previous one by disconnecting the event handler once there are tracks in the library. This should fix this bug caused by the current patch : https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/622313 It also makes the message translatable, which is this other bug : https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/619303
Review of attachment 186010 [details] [review]: Looks good to me, bertrand
Comment on attachment 186010 [details] [review] Show a message if the library is empty I'll have another look at this after 2.2 is out. I'd like to implement Gabriel proposal.
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.