After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623538 - GDBusProxy::g-properties-changed emission for corner cases
GDBusProxy::g-properties-changed emission for corner cases
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gdbus
unspecified
Other All
: Normal minor
: ---
Assigned To: David Zeuthen (not reading bugmail)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-07-04 18:15 UTC by Allison Karlitskaya (desrt)
Modified: 2010-07-07 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Allison Karlitskaya (desrt) 2010-07-04 18:15:44 UTC
The only place that we see g_signal_emit for PROPERTIES_CHANGED_SIGNAL is in on_properties_changed which directly corresponds to org.freedesktop.DBus.Properties.PropertiesChanged.

The properties also change in two other situations:

  1) they are all dropped when we have a negative NameOwnerChanged

    - in this case, we should emit the signal to invalidate any properties that
      used to exist

  2) they are all filled in when we have a positive NameOwnerChanged

    - in this case, we should emit the signal with the new properties (if any)


It could be argued that it is the responsibility of the user to watch the "g-name-owner" signal in order to know when the properties have changed, but my first assumption would be that watching the "properties-changed" signal would be sufficient for that.
Comment 1 David Zeuthen (not reading bugmail) 2010-07-07 13:55:18 UTC
Sure, would be nice to handle the corner cases correctly. Fixed:

http://git.gnome.org/browse/glib/commit/?id=a38fed1b43cb688001c6343cc30022013c0ea25b