After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623533 - totem-pl-parser fails to build outside source tree (again)
totem-pl-parser fails to build outside source tree (again)
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
2.30.x
Other All
: Normal normal
: ---
Assigned To: totem-pl-parser-maint
totem-pl-parser-maint
Depends on:
Blocks: 569778
 
 
Reported: 2010-07-04 15:24 UTC by Theppitak Karoonboonyanan
Modified: 2010-07-06 08:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use gobject-introspection >= 0.6.14 (2.62 KB, patch)
2010-07-04 15:33 UTC, Theppitak Karoonboonyanan 		committed Details | Review

Description Theppitak Karoonboonyanan 2010-07-04 15:24:14 UTC 
After the change in bug 617892, the current totem-pl-parser trunk fails to build outside source tree again, with the error message:

---8<---
make[4]: *** No rule to make target `/home/thep/vcs/gnome_git/totem-pl-parser/plparse/totem-pl-parser-builtins.c', needed by `TotemPlParser-1.0.gir'.  Stop.
make[4]: Leaving directory `/home/thep/build/gnome_git/totem-pl-parser/plparse'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/thep/build/gnome_git/totem-pl-parser/plparse'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/thep/build/gnome_git/totem-pl-parser/plparse'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/thep/build/gnome_git/totem-pl-parser'
make: *** [all] Error 2
---8<---

As bug 616425 has been fixed for gobject-introspection, it would be good in the long run to move to the new introspection make rule.
Comment 1 Theppitak Karoonboonyanan 2010-07-04 15:33:28 UTC 
Created attachment 165228 [details] [review]
Use gobject-introspection >= 0.6.14

This patch makes it depend on gobject-introspection >= 0.6.14, undoes the split between generated and manual sources, and then removes the srcdir prefix addition to source files.
Comment 2 Philip Withnall 2010-07-06 08:38:17 UTC 
Committed, thanks.

commit ef834f5a728b439630f7314b88591915bae6d78c
Author: Theppitak Karoonboonyanan <thep@linux.thai.net>
Date:   Sun Jul 4 22:24:37 2010 +0700

    Fix non-source-dir build failure
    
    Move to new make rule in gobject-introspection >= 0.6.14, where introspection
    source files are referenced via VPATH. Distinction between generated and manual
    sources are no longer needed.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=623533
    
    Signed-off-by: Theppitak Karoonboonyanan <thep@linux.thai.net>

 configure.in        |    2 +-
 plparse/Makefile.am |   19 +++++--------------
 2 files changed, 6 insertions(+), 15 deletions(-)