After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623519 - [PATCH] Some fixes to Vala bindings
[PATCH] Some fixes to Vala bindings
Status: RESOLVED DUPLICATE of bug 621246
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other Linux
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-04 11:54 UTC by Sean McNamara
Modified: 2010-07-04 12:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Install Vala bindings into system vapi dir (9.19 KB, patch)
2010-07-04 11:54 UTC, Sean McNamara
none Details | Review

Description Sean McNamara 2010-07-04 11:54:07 UTC
Created attachment 165217 [details] [review]
Install Vala bindings into system vapi dir

With this patch, a standard ./configure --enable-vala && make && make install will cause Vala bindings to be installed in VAPIDIR (usually /usr/share/vala/vapi).

Secondly, I changed the name of rb.vapi and rb.deps to rhythmbox.vapi and rhythmbox.deps. That's because every other .vapi I have ever seen has an identical basename to the pkg-config file. Since Jonathan named it rhythmbox.pc, it makes sense (by Vala convention) to name it rhythmbox.vapi.

Also included, the .vapi has been fixed up to properly build from the out-of-tree headers. The .deps has been updated to add `rhythmbox', which makes it include pkg-config --cflags --libs when you specify --pkg=rhythmbox to valac.

It is now straightforward to compile and link your Vala plugin from out of tree.

I should be able to pull out the rename into a separate patch if desired. The other fixes are pretty much taken as a whole: without them, we don't really do anything with the Vala bindings; with them, we need to tell Automake how to ship the Vala bindings, and then fix the bindings so that they actually work out-of-tree.

Patch is from git format-patch.
Comment 1 Jonathan Matthew 2010-07-04 12:14:33 UTC
Thanks, but we're working on this in too many places.  Closing this as a duplicate of one of the others.

*** This bug has been marked as a duplicate of bug 621246 ***