GNOME Bugzilla – Bug 623494
[TelepathyClient] Missing presence notifications
Last modified: 2010-07-04 00:35:37 UTC
When a contact changes his presence, you get: JS ERROR: !!! Exception in callback for signal: presence-changed JS ERROR: !!! message = 'args[i++] is undefined' JS ERROR: !!! lineNumber = '41' JS ERROR: !!! fileName = '/home/giovanni/gnome-shell/install/share/gnome-shell/js/misc/format.js' JS ERROR: !!! stack = '("%s","","","s",0,"%s is online.")@/home/giovanni/gnome-shell/install/share/gnome-shell/js/misc/format.js:41 format((void 0))@/home/giovanni/gnome-shell/install/share/gnome-shell/js/misc/format.js:20 (2,"")@/home/giovanni/gnome-shell/install/share/gnome-shell/js/ui/telepathyClient.js:545 ([object Object],"/org/freedesktop/Telepathy/Connection/gabble/jabber/scampa_2egiovanni_40gmail_2ecom_2fef1c8057","2",2,"")@/home/giovanni/gnome-shell/install/share/gnome-shell/js/ui/telepathyClient.js:178 ([object Object],"/org/freedesktop/Telepathy/Connection/gabble/jabber/scampa_2egiovanni_40gmail_2ecom_2fef1c8057","2",2,"")@/home/giovanni/gnome-shell/install/share/gjs-1.0/lang.js:110 _emit("presence-changed","/org/freedesktop/Telepathy/Connection/gabble/jabber/scampa_2egiovanni_40gmail_2ecom_2fef1c8057","2",2,"")@/home/giovanni/gnome-shell/install/share/gjs-1.0/signals.js:124 ([object Object],[object Object])@/home/giovanni/gnome-shell/install/share/gnome-shell/js/ui/telepathyClient.js:315 ([object Object],[object Object])@/home/giovanni/gnome-shell/install/share/gjs-1.0/lang.js:110 _invokeSignalWatchCallback((function () {var args = Array.prototype.slice.call(arguments);args = args.concat(bindArguments);return callback.apply(me, args);}),[object Object],[object Object])@/home/giovanni/gnome-shell/install/share/gjs-1.0/dbus.js:172 ([object Object])@/home/giovanni/gnome-shell/install/share/gjs-1.0/dbus.js:187 ' From fast testing, it appears the problems is that 'name' is not a valid property for Telepathy message tray Sources.
Created attachment 165199 [details] [review] [TelepathyClient] Fix notification of presence change
Review of attachment 165199 [details] [review]: Thanks for the catch - this.name was renamed recently, seemed like those were missed. The fix is fine, but your commit message needs a body. Can be as brief as: When renaming Source.name to Source.title in commit 83689e4 some references were missed, which broke presence change notifications.
I just thought the fix was too small to deserve a body (and wasn't aware of commit 83689e4). Do I need to post an updated patch or will you handle that?
Attachment 165199 [details] pushed as 7b79e2e - [TelepathyClient] Fix notification of presence change (In reply to comment #3) > I just thought the fix was too small to deserve a body Except for the most trivial changes ("Fix typo", "Add missing semicolon", ...) a short explanation (the "why" of the change) can be extremely helpful. For example, let's assume that this fix conflicts with the patch series in bug 620416 (it might, I have no idea). With the explanation it's possible to understand that the change is more than stupid variable renaming (let's face it, "name" is much more appropriate for a contact than "title") - ideally, it can even prevent other this.name references to be reintroduced by the series.