After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623384 - [ffmpegcolorspace] Doesn't write last pixel for odd widths in packed 4:2:2 YUV->RGB conversion
[ffmpegcolorspace] Doesn't write last pixel for odd widths in packed 4:2:2 YU...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.30
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-02 12:56 UTC by Sebastian Dröge (slomo)
Modified: 2010-07-02 13:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ffmpegcolorspace: Fix conversion of packed 4:2:2 YUV to RGB (1.83 KB, patch)
2010-07-02 12:56 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2010-07-02 12:56:01 UTC
Attached patch fixes this, problem can easily be shown be this pipeline:

GST_REGISTRY_UPDATE=no G_SLICE=always-malloc valgrind --track-origins=yes ../../../gstreamer/tools/.libs/gst-launch-0.10 videotestsrc num-buffers=1 ! ffmpegcolorspace ! "video/x-raw-rgb,bpp=32,depth=32,alpha_mask=255,width=641,height=481" ! videoscale method=2 ! "video/x-raw-rgb,width=111,height=30" ! fakesink
Comment 1 Sebastian Dröge (slomo) 2010-07-02 12:56:46 UTC
Created attachment 165105 [details] [review]
ffmpegcolorspace: Fix conversion of packed 4:2:2 YUV to RGB

The last pixel wasn't written before.

Fixes bug #623384.
Comment 2 Sebastian Dröge (slomo) 2010-07-02 13:46:56 UTC
commit 9c9f97251a44cb4f05993cbe9dabfc40560a147f
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri Jul 2 14:56:02 2010 +0200

    ffmpegcolorspace: Fix conversion of packed 4:2:2 YUV to RGB
    
    The last pixel wasn't written before.
    
    Fixes bug #623384.