After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623366 - [qtdemux] strip out bogus tags from XMP
[qtdemux] strip out bogus tags from XMP
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-02 10:20 UTC by Edward Hervey
Modified: 2010-07-02 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtdemux: strip out bogus tags from XMP atom (877 bytes, patch)
2010-07-02 10:32 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2010-07-02 10:20:24 UTC 
qtdemux pushes out all tags contained in a XMP tag. The problem is that it might contain bogus tags, like the codec/format tags, resulting in pushing out wrong information downstream.

See also #623365
Comment 1 Edward Hervey 2010-07-02 10:32:45 UTC 
Created attachment 165086 [details] [review]
qtdemux: strip out bogus tags from XMP atom
Comment 2 Thiago Sousa Santos 2010-07-02 11:41:36 UTC 
Shouldn' t it remove audio/container too?
Comment 3 Tim-Philipp Müller 2010-07-02 12:11:59 UTC 
Makes sense to me , let's put it in.

I suspect there's no need to remove the audio/container tags because the XMP code in libgsttag doesn't serialise/deserialise those.
Comment 4 Edward Hervey 2010-07-02 12:39:49 UTC 
Attachment 165086 [details] pushed as fcf1995 - qtdemux: strip out bogus tags from XMP atom