GNOME Bugzilla – Bug 623292
"Error while saving song information" (ogg file album name update)
Last modified: 2012-10-06 11:59:53 UTC
When trying to change the album name for a group-selection of ogg tracks in Rhythmbox (PPC Lucid), I get many windows that say "Error while saving song information" and: "Internal GStreamer problem; file a bug" "Internal data stream error." This is after the album name appears to change correctly in Rhythmbox. Then, once these dialogs pop up, some of the tracks' album names (about 2 out of 5 tracks) start to randomly revert in Rhythmbox. Attempting to change the album name again on the tracks that didn't change before changes most of them, again seemingly randomly. Sometimes, all of the track info changes even if a dialog pops up. Also, changing the track info using Exaile reproduces the same errors in Rhythmbox. Dialogs pop up in Rhythmbox and not all tracks are changed. The files I tried it on (about 12-22 minutes/ 6-11 MB ea.) were from this 172 MB zip file: http://dhammatalks.org/Archive/All_09_October_OGG.zip I also tested the following small file but had no issues: http://upload.wikimedia.org/wikipedia/commons/a/a9/Tromboon-sample.ogg I might file another bug for the following issue, but it might be a hint for the current problem: When playing the longer tracks mentioned above, the track often jumps ahead by a fraction of a second. For instance, this occurs on track number 01 at 0:26, 0:43, and 1:00 minutes, etc. This is not an issue on my RockBox portable music player, suggesting that the files aren't the problem in this way at least.
When changing the tag info on problematic ogg tracks from Rhythmbox or even another program, errors pop up like above. Also, some tracks revert tag info and some change permissions from 644 to 600; some do both. Changing the permissions back to 644 gives more errors, and the track info reverts to the wrong value again on some of those tracks. If I select all of the problematic tracks in Rhythmbox, including those with correct and incorrect tag info, and enter the correct tag info in the music properties dialog, then even some of the tracks with correct track info will change their tags or permissions, but infrequently. I also tried removing the problematic tracks from Rhythmbox's database, changing their tags and then bringing them back into the library. When I did this, I got more errors, but their tags did not revert. This is strange as when these tracks are copied directly from the downloaded archive into the music directory for Rhythmbox, there are no errors. I've tried this using the following smaller (59 MB) archive of ogg tracks and have gotten the same errors: http://dhammatalks.org/Archive/All_09_December_OGG.zip
The permissions change hints that there's some new fle being generated, then the old file is removed, and the new one renamed to it. If there's a failure somewhere, some of the steps may be skipped. The reverting may be that Rythmbox keeps a cache/database. It does sound odd.
Trying a simple vorbistag pipeline on the files from that smaller archive, everything seems to work fine, valgrind's happy. If you're still seeing this with current gstreamer, and it happens often enough, you can run rythmbox like this: GST_DEBUG=3,*ogg*:5,*vorbis*:5 rhythmbox >& rb.log Then go about repdoducing the issue. Then quit rhythmbox, compress the log and attach it. It may or may not be enough to work out what the issue is, but a full 5 log on a possibly high number of pipelines will be very very large indeed so let's try the smaller one first.
In fact, while testing on that file set, I found leaks, which in turn unearthed possible corruption of the audio data, see https://bugzilla.gnome.org/show_bug.cgi?id=669167. Since this is in the Vorbis parser, which is used as a base for the tagger, there is some chance that this might cause your issue. Can you try with this patch and see if you get that problem again ?
I tested the small archive mentioned above that was giving me problems in Rhythmbox, this time on Debian Wheezy. I was able to change track information on multiple tracks, without any info reverting. Therefore, I did not go ahead and try your patch yet. I did notice what seemed to be tiny little glitches in the playback in Rhythmbox, as if the track was stopping for tiny bits. This happens only after updating track info in rb. When I seeked backwards to replay one of the glitched sections of the audio a second time, I heard the glitch again in the same spot. However, I did not notice those glitches when I played that file with vlc. Also, file sizes changed somewhat drastically after changing artist, album and genre to "testing" in rhythombox: sudoman@igo Downloads$ ls -l orig/2009/ total 60056 -r--r--r-- 1 sudoman sudoman 8271990 Jan 3 2010 091222 Inner Discontent.ogg -r--r--r-- 1 sudoman sudoman 6102886 Jan 3 2010 091224 Peace on Earth.ogg ... sudoman@igo Downloads$ ls -l mod-rhythmbox/2009/ total 59820 -r--r--r-- 1 sudoman sudoman 8247931 Jan 3 2010 091222 Inner Discontent.ogg -r--r--r-- 1 sudoman sudoman 6084317 Jan 3 2010 091224 Peace on Earth.ogg ... sudoman@igo Downloads$ ls -l mod-exfalso/2009/ total 60056 -rw-rw-r-- 1 sudoman sudoman 8271979 Feb 3 17:25 091222 Inner Discontent.ogg -rw-rw-r-- 1 sudoman sudoman 6102875 Feb 3 17:25 091224 Peace on Earth.ogg ... sudoman@igo Downloads$ ls -l mod-exfalso-comment-removed/2009/ total 60048 -rw-rw-r-- 1 sudoman sudoman 8271591 Feb 3 17:27 091222 Inner Discontent.ogg -rw-rw-r-- 1 sudoman sudoman 6102487 Feb 3 17:27 091224 Peace on Earth.ogg ... I may give your patch a shot sometime in the future. Thanks for your work. :) Package: gstreamer0.10-plugins-good Source: gst-plugins-good0.10 Version: 0.10.30-2.1
The tiny glitches would be totally consistent with packets being dropped. Assuming even distribution of first byte over (0-127)<<1 (which I have no idea if it's true, but is a fair first guess), there would be a bit less than 2% of packets dropped. So my patch should remove all those glitches being inflicted on those poor files after tagging. It's crazy this hasn't been seen before :S
Andrew, do you have any update for patch testing ?
Ok, so I tested this on Debian Wheezy in Rhythmbox. According to the bug linked above, the fix was cherry-picked into 0.10.36. I have these installed: gstreamer0.10-plugins-base: Installed: 0.10.36-1 gstreamer0.10-plugins-good: Installed: 0.10.31-1 From what I could glean online, the ogg decoder is in -base, so I should have the patch applied automatically in this distribution. I changed the album name for freshly unzipped versions of those tracks in rhythmbox and listened to several minutes of the audio. I did not notice any dropped packets like I did before, or reverting metadata. Do you need me to boot into an older distro, change track names there, and then try playing in wheezy's rhythmbox? Thanks! :) -Andrew