GNOME Bugzilla – Bug 623280
Creating new Calendar/Addressbook/TaskList/MemoList doesn't get reflected on server
Last modified: 2010-07-09 10:04:18 UTC
Steps to reproduce 1. Create a New Calendar/Address book/Task List/Memo List in MAPI 2. Disable and Enable MAPI account 3. Not able to see the created items Warning on creating new Calendar : (evolution:12795): libexchangemapi-CRITICAL **: exchange_mapi_connection_find: assertion `profile != NULL' failed (evolution:12795): libexchangemapi-CRITICAL **: exchange_mapi_connection_find: assertion `profile != NULL' failed ** (evolution:12795): CRITICAL **: exchange_mapi_cal_commit: assertion `conn != NULL' failed
Created attachment 165024 [details] [review] Evolution MAPI Patch Profile was not set for new created esource.No code was there to created Address book on the server. bug #623263 is also fixed with this patch.
*** Bug 623263 has been marked as a duplicate of this bug. ***
Thanks for a patch. It looks good except of one thing, the 'tmp' in exchange_mapi_create is leaking, though not always. I didn't know the inconsistency in this, but e_source_get_property returns const gchar *, but e_source_group_get_property return gchar *, which should be freed. You should make sure this will be good for both cases. Because you are using the 'tmp' only for a profile name, please rename it to 'profile', so it'll be less cryptic. (Not that I do not like 'tmp' variables, I use them too, just in this particular case might be better to name it.) Please update the patch and let Bharath commit it, so it'll be in the Monday release. Thanks in advance.
Created attachment 165532 [details] [review] Evolution MAPI Patch Thanks for review. I have made appropriate changes and it looks good now.
Thanks. Patch looks good. I didn't test it, but the changes seems reasonable. Created commit 0803087 in ema master (0.31.5+)