After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623280 - Creating new Calendar/Addressbook/TaskList/MemoList doesn't get reflected on server
Creating new Calendar/Addressbook/TaskList/MemoList doesn't get reflected on ...
Status: RESOLVED FIXED
Product: evolution-mapi
Classification: Applications
Component: miscellaneous
0.31.x
Other Linux
: Normal normal
: ---
Assigned To: evolution-mapi-maint
evolution-mapi-maint
: 623263 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-07-01 10:29 UTC by Punit Jain
Modified: 2010-07-09 10:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Evolution MAPI Patch (3.18 KB, patch)
2010-07-01 12:50 UTC, Punit Jain
reviewed Details | Review
Evolution MAPI Patch (3.24 KB, patch)
2010-07-09 07:44 UTC, Punit Jain
committed Details | Review

Description Punit Jain 2010-07-01 10:29:29 UTC
Steps to reproduce
1. Create a New Calendar/Address book/Task List/Memo List in MAPI 
2. Disable and Enable MAPI account
3. Not able to see the created items

Warning on creating new Calendar :

(evolution:12795): libexchangemapi-CRITICAL **: exchange_mapi_connection_find: assertion `profile != NULL' failed

(evolution:12795): libexchangemapi-CRITICAL **: exchange_mapi_connection_find: assertion `profile != NULL' failed

** (evolution:12795): CRITICAL **: exchange_mapi_cal_commit: assertion `conn != NULL' failed
Comment 1 Punit Jain 2010-07-01 12:50:48 UTC
Created attachment 165024 [details] [review]
Evolution MAPI Patch

Profile was not set for new created esource.No code was there to created Address book on the server.
bug #623263 is also fixed with this patch.
Comment 2 Punit Jain 2010-07-01 12:52:59 UTC
*** Bug 623263 has been marked as a duplicate of this bug. ***
Comment 3 Milan Crha 2010-07-08 20:12:28 UTC
Thanks for a patch. It looks good except of one thing, the 'tmp' in exchange_mapi_create is leaking, though not always. I didn't know the inconsistency in this, but e_source_get_property returns const gchar *, but e_source_group_get_property return gchar *, which should be freed. You should make sure this will be good for both cases. Because you are using the 'tmp' only for a profile name, please rename it to 'profile', so it'll be less cryptic. (Not that I do not like 'tmp' variables, I use them too, just in this particular case might be better to name it.)

Please update the patch and let Bharath commit it, so it'll be in the Monday release. Thanks in advance.
Comment 4 Punit Jain 2010-07-09 07:44:53 UTC
Created attachment 165532 [details] [review]
Evolution MAPI Patch

Thanks for review. I have made appropriate changes and it looks good now.
Comment 5 Milan Crha 2010-07-09 10:04:08 UTC
Thanks. Patch looks good. I didn't test it, but the changes seems reasonable.

Created commit 0803087 in ema master (0.31.5+)