After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623239 - also show num-lock warning
also show num-lock warning
Product: gtk+
Classification: Platform
Component: Widget: Other
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Depends on:
Reported: 2010-06-30 19:44 UTC by William Jon McCann
Modified: 2012-10-15 22:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

[gdk] Add gdk_keymap_get_num_lock_state (6.61 KB, patch)
2010-07-01 23:01 UTC, William Jon McCann
none Details | Review
Show lock warning for num lock as well as caps lock (1.03 KB, patch)
2010-07-01 23:01 UTC, William Jon McCann
committed Details | Review
[gdk] Add gdk_keymap_get_num_lock_state (6.29 KB, patch)
2010-07-01 23:11 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2010-06-30 19:44:45 UTC
We have a nice warning icon when caps lock mode is enabled when using an entry with invisible characters.  It would help helpful to have something similar for NumLock.  This is particularly useful on some netbooks/small-keyboards where the enable numlock option is easily triggered and there isn't an obvious modal indicator.
Comment 1 William Jon McCann 2010-07-01 23:01:48 UTC
Created attachment 165057 [details] [review]
[gdk] Add gdk_keymap_get_num_lock_state
Comment 2 William Jon McCann 2010-07-01 23:01:50 UTC
Created attachment 165058 [details] [review]
Show lock warning for num lock as well as caps lock
Comment 3 William Jon McCann 2010-07-01 23:11:34 UTC
Created attachment 165059 [details] [review]
[gdk] Add gdk_keymap_get_num_lock_state
Comment 4 Matthias Clasen 2010-07-02 00:27:10 UTC
Review of attachment 165059 [details] [review]:

Looks good.
Comment 5 William Jon McCann 2010-07-02 00:30:38 UTC
I should point out that I have no way of testing the win32, quartz, etc backends...
Comment 6 Matthias Clasen 2010-07-02 00:36:49 UTC
Review of attachment 165058 [details] [review]:

Looks good. I guess we should maybe ask Jimmac about nicer icons for these
Comment 7 Marc-Andre Lureau 2012-10-15 22:12:28 UTC
I have f17 on a t410, I use gtk+ 3.4 branch, and it doesn't seem to set the numlock state when I toggle it. Apparently, update_lock_state() doesn't get called when I press num lock.

I wonder if I should open a different bug or I am missing something.

(fyi, I would like to use that function from spice-gtk, to sync modifiers, though I would also need a get_scroll_lock())