After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623230 - [git] Add optional branch attributes to snapshot
[git] Add optional branch attributes to snapshot
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2010-06-30 18:31 UTC by Dirk Wallenstein
Modified: 2010-07-03 07:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[git] Add optional branch attributes to snapshot (1.18 KB, patch)
2010-06-30 18:31 UTC, Dirk Wallenstein 		reviewed Details | Review
[git] Add optional branch attributes to snapshot (1.18 KB, patch)
2010-07-03 07:51 UTC, Dirk Wallenstein 		none Details | Review

Description Dirk Wallenstein 2010-06-30 18:31:53 UTC 
Most importantly this adds the 'checkoutdir' attribute, which is
necessary to reuse the moduleset snapshot with the originating
checkoutroot.
Comment 1 Dirk Wallenstein 2010-06-30 18:31:56 UTC 
Created attachment 164984 [details] [review]
[git] Add optional branch attributes to snapshot
Comment 2 Frederic Peters 2010-07-02 21:31:20 UTC 
Review of attachment 164984 [details] [review]:

Just a little typo to fix.

::: jhbuild/versioncontrol/git.py
@@ +441,3 @@
+            attrs['revision'] = self.branch
+        if self.checkoutroot:
+            attrs['checkoutdir'] = self.checkoutdir

You test for checkoutroot but use self.checkoutdir afterwards.
Comment 3 Dirk Wallenstein 2010-07-03 07:51:12 UTC 
Created attachment 165169 [details] [review]
[git] Add optional branch attributes to snapshot

Most importantly this adds the 'checkoutdir' attribute, which is
necessary to reuse the moduleset snapshot with the originating
checkoutroot.
Comment 4 Frederic Peters 2010-07-03 07:53:25 UTC 
Thanks; pushed.

commit e7df839dcffbe1ca06153e56c3042b00fff419a1
Author: Dirk Wallenstein <halsmit@t-online.de>
Date:   Wed Jun 30 13:06:43 2010 +0200

    Add optional branch attributes to snapshot
    
    Most importantly this adds the 'checkoutdir' attribute, which is
    necessary to reuse the moduleset snapshot with the originating
    checkoutroot.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=623230