After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623229 - Fix a crash in the Python loader if Python initialisation failed
Fix a crash in the Python loader if Python initialisation failed
Status: RESOLVED FIXED
Product: libpeas
Classification: Platform
Component: python
git master
Other Linux
: Normal normal
: ---
Assigned To: libpeas-maint
libpeas-maint
Depends on:
Blocks: 622963
 
 
Reported: 2010-06-30 18:15 UTC by Philip Withnall
Modified: 2010-06-30 18:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix a crash in the Python loader if Python initialisation failed (1.38 KB, patch)
2010-06-30 18:15 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2010-06-30 18:15:38 UTC 
Created attachment 164983 [details] [review]
Fix a crash in the Python loader if Python initialisation failed

Patch attached to fix a crash in the Python loader if Python initialisation failed; we tried to acquire the Python GIL in the add module function, which is A Bad Idea if Python initialisation failed.
Comment 1 Steve Frécinaux 2010-06-30 18:19:47 UTC 
Review of attachment 164983 [details] [review]:

Looks fine. You can push this patch to master.
Comment 2 Philip Withnall 2010-06-30 18:23:43 UTC 
commit c6aaf6f75ddd7676d23462975f34ecbbf7f637a7
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Jun 30 19:13:52 2010 +0100

    Fix a crash in the Python loader if Python initialisation failed
    
    The loader would try to acquire the Python GIL when adding a module director
    which would cause a crash.

 loaders/python/peas-plugin-loader-python.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)