After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623225 - gdm user manager ignores /etc/login.defs and has hard-coded DEFAULT_MINIMAL_UID
gdm user manager ignores /etc/login.defs and has hard-coded DEFAULT_MINIMAL_UID
Status: RESOLVED NOTGNOME
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-30 17:18 UTC by Kees Cook
Modified: 2011-05-17 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
examine login.defs for MIN_UID (10.30 KB, patch)
2010-06-30 17:22 UTC, Kees Cook 		needs-work Details | Review

Description Kees Cook 2010-06-30 17:18:27 UTC 
The GDM user manager has a hard-coded DEFAULT_MINIMAL_UID instead of checking the system MIN_UID in /etc/login.defs.  This causes users to vanish from GDM that used to be able to log in (if they had a UID below the hardcoded GDM value).

The attached patch fixes this problem.

https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/427462
https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/459199
Comment 1 Kees Cook 2010-06-30 17:22:01 UTC 
Created attachment 164979 [details] [review]
examine login.defs for MIN_UID
Comment 2 Brian Cameron 2010-06-30 19:38:59 UTC 
Wouldn't it be better to check in the configure script if /etc/login.defs exists on the system and #ifdef the code based on that.  OpenSolaris does not have /etc/login.defs.  I notice that you use "#ifndef __sun" which will probably keep things working on OpenSolaris, however I'd bet other distros may not have this file as well.
Comment 3 Ray Strode [halfline] 2010-06-30 20:58:58 UTC 
login.defs file is optional anyway, so the patch should make sure that it's not an error condition that the file is absent.
Comment 4 Ray Strode [halfline] 2010-12-17 19:32:05 UTC 
So I think this patch should go in the fdo accountsservice module, since we're going to be depending on that in gnome 3.
Comment 5 Benedikt Morbach 2011-03-02 02:13:07 UTC 
Bug filed at fdo: https://bugzilla.freedesktop.org/show_bug.cgi?id=34893
Comment 6 Ray Strode [halfline] 2011-05-17 17:39:20 UTC 
This got fixed a while ago.