After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623006 - [patch] port from unique to GApplication
[patch] port from unique to GApplication
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: Disks UI
3.0.x
Other All
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
gnome-disk-utility-maint
Depends on:
Blocks: 658402
 
 
Reported: 2010-06-28 06:26 UTC by Saleem Abdulrasool
Modified: 2012-03-05 14:51 UTC
See Also:
GNOME target: 3.4
GNOME version: 3.3/3.4

Attachments
0001-port-from-unique-to-GApplication.patch (11.20 KB, patch)
2010-06-28 06:26 UTC, Saleem Abdulrasool 		none Details | Review
0001-port-from-unique-to-GtkApplication.patch (14.38 KB, patch)
2010-06-29 01:41 UTC, Saleem Abdulrasool 		none Details | Review
0001-port-from-unique-to-GtkApplication.patch (14.66 KB, patch)
2010-07-04 18:42 UTC, Saleem Abdulrasool 		none Details | Review
0001-port-from-unique-to-GtkApplication.patch (14.76 KB, patch)
2010-08-01 19:45 UTC, Saleem Abdulrasool 		none Details | Review

Description Saleem Abdulrasool 2010-06-28 06:26:07 UTC 
Created attachment 164784 [details] [review]
0001-port-from-unique-to-GApplication.patch

The attached patch ports palimpsest from unique to GApplication.
Comment 1 David Zeuthen (not reading bugmail) 2010-06-28 15:57:17 UTC 
Wouldn't it be easier to just use GtkApplication here?

http://library.gnome.org/devel/gtk/unstable/GtkApplication.html
Comment 2 Saleem Abdulrasool 2010-06-29 01:41:08 UTC 
Created attachment 164857 [details] [review]
0001-port-from-unique-to-GtkApplication.patch

Sure, the updated patch uses GtkApplication instead.  I just didnt think it mattered much between GApplication and GtkApplication.
Comment 3 Saleem Abdulrasool 2010-07-04 18:42:03 UTC 
Created attachment 165238 [details] [review]
0001-port-from-unique-to-GtkApplication.patch

Tweak patch to not hardcode the names in the invocation.
Comment 4 Saleem Abdulrasool 2010-08-01 19:45:41 UTC 
Created attachment 166940 [details] [review]
0001-port-from-unique-to-GtkApplication.patch

Updated for newer APIs and fixes an issue with GTK+ 2.0 and 3.0 symbols being used simultaneously.
Comment 5 André Klapper 2011-03-03 20:52:25 UTC 
[Removing GNOME3.0 target as decided in release-team meeting on March 03, 2011. "nice-to-have" categorisation for GNOME3.0; Patch available]
Comment 6 Javier Jardón (IRC: jjardon) 2012-01-11 18:28:23 UTC 
This was done in the udisks2 branch:

http://git.gnome.org/browse/gnome-disk-utility/log/?h=udisks2-port
Comment 7 Javier Jardón (IRC: jjardon) 2012-03-05 14:51:09 UTC 
udisks2-port was merged, so we can close this now :)