GNOME Bugzilla – Bug 622961
Move TotemDiscMediaType get_type() and quark() functions from Totem
Last modified: 2010-06-27 22:31:58 UTC
Created attachment 164755 [details] [review] Move TotemDiscMediaType get_type() and quark() functions from Totem Since the TotemDiscMediaType struct lives in totem-pl-parser, it makes sense for its get_type() and quark() functions to live in totem-pl-parser too.
Looks fine to commit except that the piece of C code should be generated using glib-mkenums, to avoid having to update it by hand in the future (if need be).
commit 14b9b021554e054a748d2a9ffc9b9e243e2c6202 Author: Philip Withnall <philip@tecnocode.co.uk> Date: Sat Jun 26 22:03:32 2010 +0100 Move TotemDiscMediaType get_type() and quark() functions from Totem plparse/Makefile.am | 10 +++++----- plparse/plparser.symbols | 2 ++ plparse/totem-disc.c | 10 ++++++++++ plparse/totem-disc.h | 6 +++++- plparse/totem-pl-parser-builtins.h | 7 +++++-- 5 files changed, 27 insertions(+), 8 deletions(-)