After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622951 - Add override for TreeModelSort
Add override for TreeModelSort
Status: RESOLVED INVALID
Product: pygobject
Classification: Bindings
Component: introspection
Git master
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks: 622963
 
 
Reported: 2010-06-27 16:13 UTC by Philip Withnall
Modified: 2010-06-28 21:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add override for TreeModelSort (1.75 KB, patch)
2010-06-27 16:13 UTC, Philip Withnall 		none Details | Review

Description Philip Withnall 2010-06-27 16:13:02 UTC 
Patch coming to add an override for TreeModelSort to improve the behaviour of TreeModelSort.convert_child_iter_to_iter(). Test case included, but as bug bug #622882 I can't run the test suite, so I'm not sure if the test case works properly. The overridden function itself works fine in a Totem plugin.
Comment 1 Philip Withnall 2010-06-27 16:13:44 UTC 
Created attachment 164751 [details] [review]
Add override for TreeModelSort
Comment 2 Paolo Borelli 2010-06-28 12:23:31 UTC 
Review of attachment 164751 [details] [review]:

::: gi/overrides/Gtk.py
@@ +428,3 @@
+        sort_iter = Gtk.TreeIter()
+
+        if (Gtk.TreeModelSort.convert_child_iter_to_iter(self, sort_iter, child_iter)):

why the surrounding "()"? it is python :)

Apart from that patch looks ok to me
Comment 3 johnp 2010-06-28 15:27:24 UTC 
This override is not needed.  The fix is to annotate API that takes user allocated treeiters with (out) in GTK+.
Comment 4 Philip Withnall 2010-06-28 21:01:23 UTC 
Ah, that's a much tidier solution, thanks. Filed as bug #623068 against GTK+.