After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622944 - Require automake 1.9 or newer for $(builddir)
Require automake 1.9 or newer for $(builddir)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.30
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-27 14:48 UTC by Guido Günther
Modified: 2010-06-28 15:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Require automake 1.9 (1.17 KB, patch)
2010-06-27 14:48 UTC, Guido Günther 		none Details | Review

Description Guido Günther 2010-06-27 14:48:51 UTC 
Created attachment 164747 [details] [review]
Require automake 1.9

Attached patch changes the minimum required automake version from 1.7 to 1.9. If 1.7 gets picked up by the buildsystem $(builddir) is undefined which makes the build faile in in the patsubst expressions containing $(builddir).
Comment 1 Sebastian Dröge (slomo) 2010-06-27 15:02:44 UTC 
I thought $(builddir) was removed again in automake 1.11 or something... so maybe we simply shouldn't use it
Comment 2 Guido Günther 2010-06-27 15:10:04 UTC 
It's there in 1.11 (which is what I'm building with) and it's listed here:

http://www.gnu.org/software/hello/manual/autoconf/Preset-Output-Variables.html
Comment 3 Tim-Philipp Müller 2010-06-28 08:33:11 UTC 
I think it's fine to bump the automake requirement to 1.9 or 1.10 (released in 2004 and 2006 resp.).
Comment 4 Tim-Philipp Müller 2010-06-28 15:08:31 UTC 
Let's just bump it to 1.10:

commit a6fc8a8738b8645e3c0c042ff46004640a757441
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Mon Jun 28 15:43:30 2010 +0100

    Bump automake requirement to 1.10
    
    For maintainability reasons and $(builddir).
    
    Fixes #622944.