After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622934 - Migrate from dbus-glib to glib's GDBus
Migrate from dbus-glib to glib's GDBus
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other Linux
: Normal enhancement
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks: 622871
 
 
Reported: 2010-06-27 11:44 UTC by André Klapper
Modified: 2013-05-24 21:29 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description André Klapper 2010-06-27 11:44:28 UTC
For GLib 2.25.5 GDBus D-Bus support was merged, providing an API to replace dbus-glib.

See http://library.gnome.org/devel/gio/unstable/gdbus.html and http://library.gnome.org/devel/gio/unstable/ch28.html .

According to a quick grep this module seems to use dbus-glib:

./gimp/configure.ac:  PKG_CHECK_MODULES(DBUS_GLIB, dbus-glib-1 >= dbus_glib_required_version,
Comment 1 Martin Nordholts 2011-03-14 07:16:48 UTC
Low priority compared to things on our roadmap, moving off milestone
Comment 2 Michael Natterer 2013-05-24 21:29:34 UTC
Fixed in master:

commit c4460e846b55304afd262add2ca61dd69bf468a5
Author: Michael Natterer <mitch@gimp.org>
Date:   Fri May 24 23:25:47 2013 +0200

    Bug 622934 - Migrate from dbus-glib to glib's GDBus
    
    Drop the glib-dbus dependency and port stuff to GDBus. Use it
    unconditionally if not on Windows or OSX. It seels to work just like
    before but I have no idea if everything is really correct.

 INSTALL                   |   20 +++----
 app/gui/.gitignore        |    3 +-
 app/gui/Makefile.am       |   16 ++++--
 app/gui/dbus-service.xml  |    5 +-
 app/gui/gimpdbusservice.c |  144 ++++++++++++++++++++++++-------------------------
 app/gui/gimpdbusservice.h |   38 +++++--------
 app/gui/gui-unique.c      |  162 +++++++++++++++++++++++++++++--------------------------
 app/unique.c              |    4 +-
 configure.ac              |   39 ++++----------
 9 files changed, 201 insertions(+), 230 deletions(-)