After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622912 - Migrate from dbus-glib to glib's GDBus
Migrate from dbus-glib to glib's GDBus
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.32.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Milan Crha
Evolution QA team
evolution[cleanup]
Depends on:
Blocks: 622871
 
 
Reported: 2010-06-27 11:25 UTC by André Klapper
Modified: 2013-09-13 01:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
evo patch (21.39 KB, patch)
2010-07-28 14:21 UTC, Milan Crha 		committed Details | Review

Description André Klapper 2010-06-27 11:25:21 UTC 
For GLib 2.25.5 GDBus D-Bus support was merged, providing an API to replace dbus-glib.

See http://library.gnome.org/devel/gio/unstable/gdbus.html and http://library.gnome.org/devel/gio/unstable/ch28.html .

According to a quick grep this module seems to use dbus-glib:

./evolution/configure.ac:
m4_define([dbus_glib_minimum_version], [0.74])
PKG_CHECK_MODULES([DBUS_GLIB], [dbus-glib-1 >= dbus_glib_minimum_version])
Comment 1 Milan Crha 2010-07-27 20:21:01 UTC 
I'm taking this, as soon as I'm done with eds (bug #622884).
Comment 2 Milan Crha 2010-07-28 14:21:27 UTC 
Created attachment 166713 [details] [review]
evo patch

for evolution;

Not so complicated, finally.
Comment 3 Milan Crha 2010-07-28 14:23:10 UTC 
Created commit 6158bce in evo master (2.31.6+)
Comment 4 Gil Forcada 2010-08-29 09:09:12 UTC 
Seems that some traces of dbus-glib still exist on evolution (master):

gil@molinet:evolution (master) $ grep -R "dbus/dbus-glib" *
calendar/gui/alarm-notify/notify-main.c:35:#include <dbus/dbus-glib.h>
capplet/anjal-settings-main.c:40:#include <dbus/dbus-glib.h>
shell/main.c:45:#include <dbus/dbus-glib.h>
Comment 5 Matthew Barnes 2010-08-29 11:43:23 UTC 
Good catch!  Fixed for 2.31.91 in:
http://git.gnome.org/browse/evolution/commit/?id=8fbcab126e2453c8cbf7b5dba5a309bf83e0a3c3