GNOME Bugzilla – Bug 622891
Migrate from dbus-glib to glib's GDBus
Last modified: 2010-10-15 03:43:03 UTC
For GLib 2.25.5 GDBus D-Bus support was merged, providing an API to replace dbus-glib. See http://library.gnome.org/devel/gio/unstable/gdbus.html and http://library.gnome.org/devel/gio/unstable/ch28.html . According to a quick grep this module seems to use dbus-glib: configure.ac:pkg_modules="gtk+-2.0 >= $REQ_GTK_VERSION, glib-2.0 >= $REQ_GLIB_VERSION, dbus-1 >= $REQ_DBUS_VERSION, dbus-glib-1 >= $REQ_DBUS_VERSION"
Created attachment 172146 [details] [review] Port to gdbus Bug #622891.
Review of attachment 172146 [details] [review]: Looks good to me. I wonder if it is really worth changing the api and exposing GVariant in the libnotify api, but not a big deal.
Comment on attachment 172146 [details] [review] Port to gdbus Seems to lose support for older servers with the icon vs image thing but that's fine I think. And I think adding the variant in the api is fine. Looks good. Thanks!
Pushed to master. (In reply to comment #2) > I wonder if it is really worth changing the api and exposing > GVariant in the libnotify api, but not a big deal. This function could be hidden behind a #if GLIB_CHECK_VERSION (2, 24, 0) if you want. (In reply to comment #3) > (From update of attachment 172146 [details] [review]) > Seems to lose support for older servers with the icon vs image thing but that's > fine I think. It wasn't deliberate at least; afaict it's still using the different hint names according to the server version.
Naw, no need. We've broken API and ABI anyway. Thanks again!