After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622861 - Slovak confirmation page for Tomboy web synchronization is broken
Slovak confirmation page for Tomboy web synchronization is broken
Status: RESOLVED FIXED
Product: tomboy
Classification: Applications
Component: General
1.2.x
Other Linux
: Normal trivial
: 1.6.0
Assigned To: Tomboy Maintainers
Tomboy Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-27 09:19 UTC by Dominik Smatana
Modified: 2011-06-10 20:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot (87.20 KB, image/png)
2010-06-27 09:21 UTC, Dominik Smatana
  Details
encoding added (599 bytes, patch)
2010-09-10 11:32 UTC, Pavol Klačanský
accepted-commit_now Details | Review
working patch (767 bytes, patch)
2010-09-10 19:44 UTC, Pavol Klačanský
committed Details | Review

Description Dominik Smatana 2010-06-27 09:19:53 UTC
Confirmation page for Tomboy web synchronization is broken for Slovak locale (see attached screenshot, probably invalid charset).
Comment 1 Dominik Smatana 2010-06-27 09:21:16 UTC
Created attachment 164734 [details]
Screenshot
Comment 2 Pavol Klačanský 2010-09-10 11:32:43 UTC
Created attachment 169941 [details] [review]
encoding added

added meta fixes diacritics problem
Comment 3 Sandy Armstrong 2010-09-10 15:51:33 UTC
If you've tested this and it works, please commit.  Good catch.
Comment 4 Pavol Klačanský 2010-09-10 16:03:20 UTC
No, I don't have tested it, because I don't like mono, I will test it now
Comment 5 Pavol Klačanský 2010-09-10 19:44:24 UTC
Created attachment 169987 [details] [review]
working patch

sorry, wrong patch, my fault :/ (I am C[student] and PHP dev)

this one has been tested ;-) and it works

sorry for previous invalid patch :/
Comment 6 Pavol Klačanský 2010-09-10 19:48:21 UTC
and now, I have to remove a lot of mono clutter
Comment 7 Sandy Armstrong 2010-09-10 20:02:17 UTC
Great, please push if you have GNOME git access, or let me know if you don't and I'll push.

Thanks for your contribution to Tomboy, I hope we see more patches from you in the future! :-)
Comment 8 Pavol Klačanský 2010-09-10 20:09:52 UTC
I don't have git access, so please, commit it

I have tested it, but check it please, my first patch to gnome project

My pleasure. I try only fix problems, that are not too hard and geeky :/ (now I am working on Intel and ACPI brightness and it is like maze :/)

Yes, if I find bug, I will try fix it, and sorry, I really don't like C# :-(

Thanks
Comment 9 Sandy Armstrong 2010-09-14 19:08:49 UTC
Unfortunately I was too busy to get this in before hard code freeze, but we will get it in next cycle for sure, and probably for 1.4.1 as well.
Comment 10 Pavol Klačanský 2010-09-15 07:21:01 UTC
thanks
Comment 11 André Klapper 2011-01-22 14:22:40 UTC
Sandy: ping - is this okay to commit now?
Comment 12 Pavol Klačanský 2011-01-23 11:06:15 UTC
yes, I have tested a long time ago, please test it and commit
Comment 13 Aaron D Borden 2011-02-20 09:00:47 UTC
bump: patch needs review
Comment 14 Aaron D Borden 2011-06-10 20:29:57 UTC
committed 6137f40ba7c5ff290c19f2358079787eca8587ef