GNOME Bugzilla – Bug 622739
Make bonobo optional
Last modified: 2010-09-20 10:55:36 UTC
We don't want to completely eliminate bonobo from Orca because we have -- and will continue to have -- users of older versions of GNOME running the latest version of Orca.* Still bonobo's out the door for GNOME 3.0. Therefore, it needs to be an optional dependency rather than a required one. * While officially that's not supported, it typically works well. Therefore, we will continue to do our best to make that possible.
Created attachment 164632 [details] [review] first attempt This works for me in GNOME 2.28 and 2.30. I'm still waiting for jhbuild to finish building so I can test it in a 3.0 environment. Not sure if this is all we need to do or not.
Created attachment 164636 [details] [review] take 2 Put back something I ripped out in the first attempt. I thought it was added back when we thought gnome-speech wouldn't be deprecated. Based on Mike Gorse's testing, it looks like it might be there for at-spi over dbus. Oops. Thanks Mike!
I still need to test that this change works in a 3.0 environment (jhbuild is still building and building....) In the meantime, does this solve the problem of the dependency?
AFAIK It's enough, but It would be great if you can make the gconf dependency optional too (but this has low priority)
(In reply to comment #4) > AFAIK It's enough, Awesome. If it gets committed immediately after I do the 2.31.4 release, is that soon enough? > It would be great if you can make the gconf dependency > optional too (but this has low priority) Oh yeah, good point.... I just opened bug 622764 for that.
(In reply to comment #5) > (In reply to comment #4) > > AFAIK It's enough, > > Awesome. If it gets committed immediately after I do the 2.31.4 release, is > that soon enough? > Perfect > > It would be great if you can make the gconf dependency > > optional too (but this has low priority) > > Oh yeah, good point.... I just opened bug 622764 for that. Thanks a lot for take care of this ;)
Comment on attachment 164636 [details] [review] take 2 http://git.gnome.org/browse/orca/commit/?id=469147ab928a2aaa4ad3b090540d8f6110f24faa
Javier, since I'm still a jhbuild n00b.... When you get a chance would you mind making the necessary adjustment to jhbuild moduleset? Thanks!
Sure, done here: http://git.gnome.org/browse/jhbuild/commit/?id=8a465930dad1e6203401a85f8f5ea62ee1ea5d2e Thanks a lot Joanmarie