After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622725 - [mpgtsparse] Doesn't remove pids from pes_pids
[mpgtsparse] Doesn't remove pids from pes_pids
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-25 12:54 UTC by Sebastian Pölsterl
Modified: 2010-06-30 17:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't free pat structure (699 bytes, patch)
2010-06-25 12:54 UTC, Sebastian Pölsterl
committed Details | Review

Description Sebastian Pölsterl 2010-06-25 12:54:19 UTC
Created attachment 164618 [details] [review]
Don't free pat structure

This is a problem if you tune to a channel which uses pid X and later tune to another channel where X is used for another table (e.g. PMT).

The code that does that was actually already there but never used because the pat structure was freed before. The commit that introduced those lines intended to fix a memory leak, I checked that thoroughly, no leak is introduced.

I already talked to Zaheer about this and he agrees with my patch.
Comment 1 Tim-Philipp Müller 2010-06-30 17:32:03 UTC
Pushed:

commit 61a885613316ce7657c36a6cd215b43f9dc67b79
Author: Sebastian Pölsterl <sebp@k-d-w.org>
Date:   Wed Jun 30 18:20:13 2010 +0100

    mpegtsparse: don't free PAT structure which may still be needed later
    
    This is a problem if you tune to a channel which uses pid X and later tune to
    another channel where X is used for another table (e.g. PMT).
    
    The code that does that was actually already there but never used because the
    pat structure was freed before. The commit that introduced those lines intended
    to fix a memory leak, but we clean things up elsewhere.
    
    Fixes #622725.