GNOME Bugzilla – Bug 622659
Clean up annotation parsing, don't try to parse invalid annotations
Last modified: 2015-02-07 16:48:55 UTC
The old parser tried to parse: @foo: some text here (other text) Reject this. We strictly require another colon at the end to parse the text in between as (option) (other option). Futher ensure we only attempt to do option parse if we find something that matches the strict regexp ([A-Za-z]+). This could be tightened further.
Created attachment 164551 [details] [review] Clean up annotation parsing, don't try to parse invalid annotations
Note this patch has the scanner pick up a lot of documentation values it missed before, but there are still a few regressions.
Created attachment 164553 [details] [review] Clean up annotation parsing, don't try to parse invalid annotations The old parser tried to parse: @foo: some text here (other text) Reject this. We strictly require another colon at the end to parse the text in between as (option) (other option). Futher ensure we only attempt to do option parse if we find something that matches the strict regexp ([A-Za-z]+). This could be tightened further. TODO: Have a warning for something that looks like an annotation, but isn't.
Attachment 164553 [details] pushed as 0a67406 - Clean up annotation parsing, don't try to parse invalid annotations
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]