After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622624 - does not recover properly from failed project loading
does not recover properly from failed project loading
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: General
0.13.x
Other Linux
: Normal minor
: 0.91
Assigned To: Jean-François Fortin Tam
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-24 15:50 UTC by Jean-François Fortin Tam
Modified: 2012-10-14 03:39 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jean-François Fortin Tam 2010-06-24 15:50:09 UTC
As reported in https://bugs.launchpad.net/ubuntu/+source/pitivi/+bug/597759

If you try to load something that is not a project file as if it was a project file (ex: run "pitivi foo.ogv"), pitivi will produce a traceback and this will affect future operations:

Traceback (most recent call last):
  • File "/usr/lib/pitivi/python/pitivi/ui/sourcelist.py", line 593 in _dialogBoxResponseCb
    self.addUris(filenames)
  • File "/usr/lib/pitivi/python/pitivi/ui/sourcelist.py", line 475 in addUris
    self.app.current.sources.addUris(files)
AttributeError: 'NoneType' object has no attribute 'sources'

This seems to put pitivi in an invalid state, preventing it from being able to import clips (and probably render) afterwards.
Comment 1 Martin Erik Werner 2012-08-09 22:47:52 UTC
Still seen in 0.15.2
Comment 2 Jean-François Fortin Tam 2012-10-14 03:39:33 UTC
Fixed with the various refactoring that occured in the development version, and triple-checked/re-fixed by the latest commits now:


commit 88dc015ef205671cae3a46bfbaf2c41819773625
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Sat Oct 13 23:26:55 2012 -0400

  project: Handle invalid projects being loaded
    
  Also prevent failed signal disconnections from breaking the application state.
  Fixes bug #622624


commit d4b77fb906f57814091ef75bf9c33322f9c764b4
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Sat Oct 13 23:23:55 2012 -0400

  project: Do not return None in _makeBackupURI
    
  It does not make sense to do the project mimetype check here (GES does it
  in the file chooser), especially with a naïve file extension check.
   
  Removing this prevents errors downstream when comparing modification times.