GNOME Bugzilla – Bug 622624
does not recover properly from failed project loading
Last modified: 2012-10-14 03:39:33 UTC
As reported in https://bugs.launchpad.net/ubuntu/+source/pitivi/+bug/597759 If you try to load something that is not a project file as if it was a project file (ex: run "pitivi foo.ogv"), pitivi will produce a traceback and this will affect future operations: Traceback (most recent call last):
+ Trace 222559
self.addUris(filenames)
self.app.current.sources.addUris(files)
This seems to put pitivi in an invalid state, preventing it from being able to import clips (and probably render) afterwards.
Still seen in 0.15.2
Fixed with the various refactoring that occured in the development version, and triple-checked/re-fixed by the latest commits now: commit 88dc015ef205671cae3a46bfbaf2c41819773625 Author: Jean-François Fortin Tam <nekohayo@gmail.com> Date: Sat Oct 13 23:26:55 2012 -0400 project: Handle invalid projects being loaded Also prevent failed signal disconnections from breaking the application state. Fixes bug #622624 commit d4b77fb906f57814091ef75bf9c33322f9c764b4 Author: Jean-François Fortin Tam <nekohayo@gmail.com> Date: Sat Oct 13 23:23:55 2012 -0400 project: Do not return None in _makeBackupURI It does not make sense to do the project mimetype check here (GES does it in the file chooser), especially with a naïve file extension check. Removing this prevents errors downstream when comparing modification times.