After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622616 - Metadata parsing of broken file causes large memory allocation.
Metadata parsing of broken file causes large memory allocation.
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Import
0.6.1
Other Linux
: Normal critical
: 0.7.2
Assigned To: F-spot maintainers
F-spot maintainers
Depends on: 623869
Blocks:
 
 
Reported: 2010-06-24 15:03 UTC by Pedro Villavicencio
Modified: 2010-08-07 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Pedro Villavicencio 2010-06-24 15:03:43 UTC
this bug has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/f-spot/+bug/597720

"See attached jpg file. When I import this the CPU maxes out and memory grows and grows until i kill the process.

I see the following in standard out after the import is kicked off:

item ImportCommand+SourceItem
cleanup context
cleanup context
FSpot.Tiff.ShortReadException: Short Read
  at FSpot.Tiff.DirectoryEntry.LoadExternal (System.IO.Stream stream) [0x00000]
  at FSpot.Tiff.ImageDirectory.LoadEntries (System.IO.Stream stream) [0x00000]
  at FSpot.Tiff.ImageDirectory.Load (System.IO.Stream stream) [0x00000]
  at FSpot.Tiff.ImageDirectory..ctor (System.IO.Stream stream, UInt32 start_position, Endian endian) [0x00000]
  at FSpot.Tiff.Header..ctor (System.IO.Stream stream) [0x00000]
  at JpegHeader.GetExifHeader () [0x00000]
  at FSpot.JpegFile.get_ExifHeader () [0x00000]
  at FSpot.JpegFile.get_Date () [0x00000]
"

The image works fine on eog though.

file:

http://launchpadlibrarian.net/50801769/badfile.jpg
Comment 1 Ruben Vermeersch 2010-06-24 15:44:47 UTC
This is no import issue and it should be solved when we switch to Taglib#. I'll make sure we test that image.
Comment 2 Ruben Vermeersch 2010-08-07 14:52:08 UTC
Looks like a corrupt file. It is read correctly by Taglib#, so it should work fine starting with F-Spot 0.7.2.