After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622559 - Changing search option should focus search entry
Changing search option should focus search entry
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
2.30.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2010-06-24 05:20 UTC by Olivier Berger
Modified: 2010-06-24 12:23 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Olivier Berger 2010-06-24 05:20:08 UTC
There's a search widget (box / bar ?) on top of the list of messages, which allows to select a header and type a quick-search string

However, when an option in the combo is selected (for instance "Subject contains"), the focus is not passed to the string input widget next to it to be able to type the subject search string :-(

This results in user typing something elsewhere in evolution's interface, which gives unexpected behaviour, like selecting another folder.

This used to work fine in 2.28 and got broken after 2.30 upgrade, AFAICT

Thanks in advance.
Comment 1 Olivier Berger 2010-06-24 05:23:23 UTC
Note that this is a forward of a bug I already reported in Debian under : http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=586906
Comment 2 Akhil Laddha 2010-06-24 10:11:22 UTC
I think now it's working as expected because search combo ( advance search options) and search bar, these two are different things, not co related. 

Advance search options work on current message list where as with search bar, you can do search on current account / all accounts as well.
Comment 3 Yves-Alexis Perez 2010-06-24 10:16:57 UTC
Well, everything here is about the search bar. One expects it to be focused when choosing something in the dropdown menu (and it worked like this in 2.28). What do you think?
Comment 4 Yves-Alexis Perez 2010-06-24 11:50:48 UTC
(In reply to comment #0)
> However, when an option in the combo is selected (for instance "Subject
> contains"), the focus is not passed to the string input widget next to it to be
> able to type the subject search string :-(
> 
> This results in user typing something elsewhere in evolution's interface, which
> gives unexpected behaviour, like selecting another folder.
>
As Matthew noted on irc, the logical behavior might change wether there's a text or not.

Basically, there's two order:

a)
  1) select a search critterion
  2) enter a search pattern
b)
  1) enter a search pattern
  2) select a search critterion

In a) case, it makes sense to focus the search bar after 1). In b) case, it might makes more sense to focus the message list. So the behavior will change wether or not there's text in the search bar.
Comment 5 Matthew Barnes 2010-06-24 12:23:26 UTC
Fixed, along with another bug where the search entry was getting cleared at inappropriate times, on master and gnome-2-30 branches:

http://git.gnome.org/browse/evolution/commit/?id=f1bad7677ab2928638f8705873d7ab599b6c99cd

http://git.gnome.org/browse/evolution/commit/?h=gnome-2-30&id=dd3ea7d670be1c1dcdf38816e7a4b1ba2bd52fca

For now the search entry always gets focus whether there's a search pattern or not, because the search bar doesn't know about the message list so it's hard to direct focus there.  But as I was fixing this I thought of adding a "focus-search-results" signal to the search bar widget so something higher up in the widget hierarchy can catch that and focus the message list or calendar or address book view or task/memo list.  I'll handle that separately.