After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622531 - Use smaller icons in g-p-s treeview
Use smaller icons in g-p-s treeview
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: gnome-power-statistics
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-06-23 20:58 UTC by Vincent Untz
Modified: 2011-01-17 11:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use smaller icons in gnome-power-statistics (1018 bytes, patch)
2011-01-17 11:31 UTC, Vincent Untz
committed Details | Review

Description Vincent Untz 2010-06-23 20:58:12 UTC
The icons in the treeview to switch between the various stats are huge. And it doesn't make it look nice. Using 32px instead of 48px would improve things, imho.
Comment 1 Richard Hughes 2010-06-24 08:03:54 UTC
Hmm, I quite like the larger icons -- does it say anything in the HIG about this?
Comment 2 Vincent Untz 2010-06-24 09:54:58 UTC
I doubt so. Let's ask Jon :-)
Comment 3 Felipe Besoaín Pino 2010-10-19 18:17:42 UTC
Vincent does Jon said something? which is the current status of this bug?
Comment 4 Fabio Durán Verdugo 2010-11-14 03:52:12 UTC
any news?
Comment 5 Fabio Durán Verdugo 2011-01-03 01:51:56 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!
Comment 6 Vincent Untz 2011-01-03 06:11:52 UTC
Jon didn't answer yet, so let's wait for Jon's answer before closing the bug...
Comment 7 William Jon McCann 2011-01-17 05:38:49 UTC
Sorry just saw this.  The disparity between the height of the icons and the height of the text makes it feel a bit unbalanced to me.  Also the icons relay very little information.  Without seeing how it looks at the smaller size I would guess it probably does look better.
Comment 8 Richard Hughes 2011-01-17 11:07:26 UTC
Vincent, feel free to commit a change to make them 32x32 then. Thanks.
Comment 9 Vincent Untz 2011-01-17 11:31:42 UTC
The following fix has been pushed:
7b1d820 Use smaller icons in gnome-power-statistics
Comment 10 Vincent Untz 2011-01-17 11:31:45 UTC
Created attachment 178497 [details] [review]
Use smaller icons in gnome-power-statistics

We use GTK_ICON_SIZE_DND (32px) instead of GTK_ICON_SIZE_DIALOG (48px).