After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622524 - Missed some 'Shell.GConf' references in switch to GSettings
Missed some 'Shell.GConf' references in switch to GSettings
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-06-23 20:26 UTC by Joseph Scheuhammer
Modified: 2010-06-25 20:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix for bgo#622524 - Missed some 'Shell.GConf' references in switch to GSettings. (4.23 KB, patch)
2010-06-23 20:29 UTC, Joseph Scheuhammer 		reviewed Details | Review
Missed some 'Shell.GConf' references in switch to GSettings. (4.26 KB, patch)
2010-06-24 15:37 UTC, Joseph Scheuhammer 		committed Details | Review

Description Joseph Scheuhammer 2010-06-23 20:26:39 UTC 
The recent patch applied to fix "Bug 622414 - Port magnifier to GSettings" [1], missed a few calls to the Shell.GConf object, specifically in magnifier.js.  As a result, changes to the magnifier settings have no effect, resulting only in the error message "Error:  no symbol 'GConf' in namespace 'Shell'".

[1] https://bugzilla.gnome.org/show_bug.cgi?id=617917
Comment 1 Joseph Scheuhammer 2010-06-23 20:29:34 UTC 
Created attachment 164430 [details] [review]
Fix for bgo#622524 -  Missed some 'Shell.GConf' references in switch to GSettings.

Replaced all calls to Shell.GConf with GConf.Client in magnifier.js.
Comment 2 Joseph Scheuhammer 2010-06-23 20:38:51 UTC 
(In reply to comment #0)

I wrote:
> The recent patch applied to fix "Bug 622414 - Port magnifier to GSettings" [1],
> ...

I meant:
The recent patch applied to fix "Bug 617917 -  Migrate to GSettings" [1],
...
[1] https://bugzilla.gnome.org/show_bug.cgi?id=617917
Comment 3 drago01 2010-06-23 22:34:18 UTC 
Review of attachment 164430 [details] [review]:

Code looks good, but please remove the bug reference from the subject and append a link to the bug report to the actual commit message.

Fine to push once you fixed up the commit message/subject.
Comment 4 Milan Bouchet-Valat 2010-06-24 11:04:47 UTC 
Hmm, indeed. Not sure how I missed this... Maybe I forgot to 'git add' the file. Thanks for the patch!
Comment 5 Joseph Scheuhammer 2010-06-24 15:37:33 UTC 
Created attachment 164517 [details] [review]
Missed some 'Shell.GConf' references in switch to GSettings.

Replaced all calls to Shell.GConf with GConf.Client in magnifier.js.
Comment 6 Joseph Scheuhammer 2010-06-24 15:47:46 UTC 
(In reply to comment #4)
> ... Maybe I forgot to 'git add' the file.

I don't think so.  Some the changes to GConf.Client were there at the top of the file.  Unfortunately, there was a number missing at the bottom.  And, I missed them too until quite recently.  My bad.

> Thanks for the patch!

No problem.  Thanks for your efforts vis-a-vis this migration.
Comment 7 drago01 2010-06-24 16:18:57 UTC 
Review of attachment 164517 [details] [review]:

Looks good.
Comment 8 Owen Taylor 2010-06-25 20:42:36 UTC 
Attachment 164517 [details] pushed as 3af4ca3 - Missed some 'Shell.GConf' references in switch to GSettings.