GNOME Bugzilla – Bug 622518
Gtranslator's comment functionality is unwieldy and prone to loss of data
Last modified: 2012-04-21 11:50:58 UTC
Version: 1.9.11~git20100610 Source: https://edge.launchpad.net/~frandieguez/+archive/mabishu Steps to add a comment ---------------------- 1. Click "Add Note" in the Context section 2. Type in your comment. 3. Press Ok at the bottom. _If you select another pair of strings in the table to the left, your comment is *GONE*_ How this could be better: ------------------------- There could simply be a text field (memo field) in the same place. 1. You click it (anywhere in it) 2. You type your comment Gtranslator then treats the file as changed and lets you save your changes with the "Save" menu item or CTRL+S. It keeps the comments in memory, instead of wiping them. Poedit has something similar to what I'm describing.
Another option is just listen to end-user-action in the text view and save all the time the comment so it will not be lost and in this way there is no need for an accept button. Just a button to close the add comment mode.
*** Bug 622516 has been marked as a duplicate of this bug. ***
Created attachment 212488 [details] [review] Update the po state to modified when a note is added
Created attachment 212490 [details] [review] Remove ok/cancel buttons to add new comments
Created attachment 212492 [details] [review] Remove ok/cancel buttons to add new comments Patch updated to leave the cancel button renamed as Done. Message is updated when buffer changes, but ui is only changed when done button is clicked.
Pushed both patched, reviewed by nacho.