After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622484 - [qtmux] missing track number tag when transcoding to aac
[qtmux] missing track number tag when transcoding to aac
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.18
Other Linux
: Normal normal
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 638481 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-06-23 11:12 UTC by Gautier Portet
Modified: 2011-01-03 15:39 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Gautier Portet 2010-06-23 11:12:48 UTC
Take any ogg/mp3/flac file with track number in tags. Trancode it with a pipeline like this:
  gst-launch-0.10 filesrc location=test.mp3 ! decodebin ! audioconvert ! faac   profile=2  ! ffmux_mp4 ! filesink location=test.m4a

The resulting file contains all metadata from original file, minus the track number tag.


( http://developer.berlios.de/bugs/?func=detailbug&bug_id=17291&group_id=3213 )
Comment 1 Tim-Philipp Müller 2010-06-23 22:30:26 UTC
Please use mp4mux instead of ffmux_mp4. You should consider ffmux_m4 unsupported.

The problem also happens with mp4mux though. The reason is that the code only knows how to put a track-number/track-count pair into an 'trkn' atom, but has no fallback for when there's only a track number or only a track count.

Not sure if there's an official or inofficial way to pack only one of the two values into that atom? (just set the other one to 0 maybe?)
Comment 2 Gautier Portet 2010-06-24 07:03:31 UTC
It happens also with files with both track number and track count.
Comment 3 Tim-Philipp Müller 2010-06-24 07:23:10 UTC
> It happens also with files with both track number and track count.

With mp4mux? What version? Please be more specific. Maybe you could attach a GST_DEBUG=qtmux:5 log?

This works fine for me with git and with qtmux/mp4mux from gst-plugins-bad 0.10.19:

$ gst-launch-0.10 filesrc location=foo.ogg num-buffers=100 ! queue ! decodebin2 ! audioconvert ! faac profile=2 ! mp4mux ! filesink location=foo.mp4

$ gst-launch-0.10 filesrc location=foo.mp4 ! decodebin2 ! fakesink -t
FOUND TAG      : found by element "qtdemux0".
     audio codec: MPEG-4 AAC audio
   language code: en
FOUND TAG      : found by element "qtdemux0".
           title: Foo
          artist: Bar
           album: Title
            date: 2009-10-26
         encoder: Xiph.Org libVorbis I 20090709 (oops)
    track number: 11
     track count: 14
 artist sortname: Bar
container format: ISO MP4/M4A
FOUND TAG      : found by element "faad0".
     audio codec: MPEG-4 AAC audio
Comment 4 Gautier Portet 2010-06-24 11:41:23 UTC
Woups, my fault. I was testing both time with ffmux_mp4.

Works fine with mp4mux, thank you.
Comment 5 Thiago Sousa Santos 2010-06-25 23:22:27 UTC
Fixed.

commit be3a4b797853e4100a4511d4443fd0f987067c63
Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk>
Date:   Fri Jun 25 20:19:20 2010 -0300

    qtmux: Write uint tags that don't have a complement
    
    Write uint tags that have complements (e.g. track-number/
    track-count) even when we only have one of them available
    and set the other one to 0.
    
    Fixes #622484
Comment 6 Jonathan Matthew 2011-01-03 15:39:50 UTC
*** Bug 638481 has been marked as a duplicate of this bug. ***