After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622401 - Migrate to GSettings
Migrate to GSettings
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: 2.26.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks: 622558
 
 
Reported: 2010-06-22 13:54 UTC by Pablo Castellano (IRC: pablog)
Modified: 2011-08-03 08:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update seahorse to gsettings (145.04 KB, patch)
2011-07-27 13:26 UTC, Stef Walter
none Details | Review
Port libcrypt to gsettings (62.06 KB, patch)
2011-07-28 09:17 UTC, Stef Walter
none Details | Review

Description Pablo Castellano (IRC: pablog) 2010-06-22 13:54:26 UTC
Migrating from GConf to GSettings is an official GNOME goal now, so we probably should get on this.

http://live.gnome.org/GnomeGoals/GSettingsMigration
Comment 1 Stef Walter 2010-06-22 16:59:40 UTC
Somehow during the migration we also need to bring the agent settings over to gnome-keyring... since that's the where the gpg-agent is going to live.
Comment 2 Pablo Castellano (IRC: pablog) 2010-06-22 19:26:07 UTC
(In reply to comment #1)
> Somehow during the migration we also need to bring the agent settings over to
> gnome-keyring... since that's the where the gpg-agent is going to live.

Let's annotate these things in the list of things to talk about at guadec :)
Comment 3 Stef Walter 2010-06-24 14:18:21 UTC
Yes, I agree. Is there time to do this correctly rather than rushed?

Because as others have brought up, I'm concerned that the crypto preferences on the desktop are rather unified rather than having one capplet gnome-keyring, another capplet for seahorse, another for seahorse-plugins, and then of course seahorse itself (which is a manager type application).
Comment 4 Pablo Castellano (IRC: pablog) 2010-08-03 19:33:55 UTC
Stef and I discussed about it in GUADEC.

A first draft of the changes is here:
http://spreadsheets.google.com/ccc?key=0Ar1ht11q4k3tdGJjSTQza0lYTm9MaDBnN0RtQzZlNUE&hl=en&pli=1#gid=0

Comments are welcome
Comment 6 Stef Walter 2010-08-03 21:08:29 UTC
Cool. Looks good.

If there end up being some questions which delay migrating seahorse-plugins, I would suggest going forward with the other stuff anyway.
Comment 7 Pablo Castellano (IRC: pablog) 2010-08-12 14:21:30 UTC
If nobody disagrees I will start working on it next week
Comment 8 Adam Schreiber 2010-08-12 16:32:12 UTC
Pablo, Those look good to me too.  I'll try to find some time to sort the plugins keys. I'm not sure what the forward path is for the applet anyway because gnome-shell doesn't have the concept of applets.
Comment 9 Stef Walter 2010-09-05 13:47:44 UTC
Pablo, in org.gnome.crypto.cache it turns out that combining the method and ttl are isn't necessarily the best all round. I know I suggested it, but now while implementing in gnome-keyring it turns out to be lousy.

Because we want to be able to store the ttl (seconds until timeout) even if the method doesn't use the ttl (such as storing in the gnome-keyring). This is a UI issue, so that when the user switches the method back to something that uses the ttl the last chosen ttl is still there.
Comment 10 Pablo Castellano (IRC: pablog) 2010-09-05 21:21:35 UTC
(In reply to comment #9)
> Pablo, in org.gnome.crypto.cache it turns out that combining the method and ttl
> are isn't necessarily the best all round. I know I suggested it, but now while
> implementing in gnome-keyring it turns out to be lousy.
> 
> Because we want to be able to store the ttl (seconds until timeout) even if the
> method doesn't use the ttl (such as storing in the gnome-keyring). This is a UI
> issue, so that when the user switches the method back to something that uses
> the ttl the last chosen ttl is still there.

Sorry Stef, but I haven't understood the problem. But anyways, do you have any better idea?
Comment 11 Stef Walter 2010-09-05 21:35:22 UTC
Sorry if I wasn't clear. What I'm suggesting is to keep gpg-cache-method and gpg-cache-ttl separate, rather than combining the values like 'idle:10' or 'timeout:20'. Instead the method (like 'timeout', 'idle' etc.) would be in the gpg-cache-method setting, and the ttl (like '10', '20' etc.) would be in gpg-cache-ttl.
Comment 12 Stef Walter 2010-09-08 01:15:31 UTC
I've done the gnome-keyring migration and added these schemas to gnome-keyring:

org.gnome.crypto.cache
org.gnome.crypto.pgp

BTW, Pablo it seems to make more sense if the org.gnome.crypto stuff would instead be in org.gnome.crypto.pgp since it's all PGP related.

You can check these out on the gsettings-migration branch of gnome-keyring on git.gnome.org. If it all looks good, then I'll merge with master. Thanks for taking a look.
Comment 13 Stef Walter 2010-09-11 20:53:26 UTC
I've merged gsettings-migration into gnome-keyring master ahead of the 2.31.90 release next week.
Comment 14 Javier Jardón (IRC: jjardon) 2011-02-11 11:39:20 UTC
Hello Stef, Can we close this, then?
Comment 15 Stef Walter 2011-02-11 16:53:20 UTC
Sadly seahorse and seahorse-plugins still need to be migrated.
Comment 16 Stef Walter 2011-07-27 13:26:57 UTC
Created attachment 192752 [details] [review]
Update seahorse to gsettings

The branch is here: http://cgit.collabora.com/git/user/stefw/seahorse.git/log/?h=gsettings
Comment 17 Stef Walter 2011-07-28 09:17:31 UTC
Created attachment 192801 [details] [review]
Port libcrypt to gsettings

Branch is here: http://cgit.collabora.com/git/user/stefw/libcryptui.git/log/?h=gsettings
Comment 18 Stef Walter 2011-07-28 10:03:11 UTC
Made some more fixes to the seahorse gsettings branch: http://cgit.collabora.com/git/user/stefw/seahorse.git/log/?h=gsettings
Comment 19 Stef Walter 2011-08-02 08:48:46 UTC
Merged into seahorse and libcryptui. Both these are now ported to gsettings.
Comment 20 Javier Jardón (IRC: jjardon) 2011-08-02 19:06:45 UTC
Can we close this bug then?
Comment 21 Stef Walter 2011-08-03 08:13:29 UTC
Yup. Let's do that.