After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622337 - shows shutdown buttons when connecting over xdmcp
shows shutdown buttons when connecting over xdmcp
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
: 622339 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-06-22 00:34 UTC by William Jon McCann
Modified: 2010-06-22 01:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix showing the correct options for non local displays (15.35 KB, patch)
2010-06-22 01:24 UTC, William Jon McCann 		none Details | Review

Description William Jon McCann 2010-06-22 00:34:01 UTC 
When we used to have the shutdown/etc buttons in the main login window we didn't show them when connected via XDMCP but instead showed a Disconnect button.

It seems that maybe in the transition to using the panel menu we lost that logic.
Comment 1 William Jon McCann 2010-06-22 00:47:52 UTC 
Indeed it seems like the bug was introduced by:

commit e53b45310bc0b83ab14fdfde1cac6e6ea22d82b7
Author: Robert Ancell <robert.ancell@canonical.com>
Date:   Thu Sep 24 15:51:10 2009 +1000

    Move shutdown buttons to menu in panel (Bug #596151)
Comment 2 William Jon McCann 2010-06-22 01:21:39 UTC 
*** Bug 622339 has been marked as a duplicate of this bug. ***
Comment 3 William Jon McCann 2010-06-22 01:24:16 UTC 
Created attachment 164271 [details] [review]
Fix showing the correct options for non local displays

Don't use properties in _init before they are set at construction.
Correct the wrong sense in a conditional.

Fixes bugs introduced by e53b45310bc0b83ab14fdfde1cac6e6ea22d82b7
Comment 4 William Jon McCann 2010-06-22 01:44:20 UTC 
Pushed to 2-30 and master.